Conversation
Signed-off-by: Yusuf Efe <120668197+yuefdev@users.noreply.github.com>
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor hooks fail on native Windows even with Git Bash installed: the style check hardcodes
/bin/bash, the Android checker relies on executing a.pyfile through the shell, and generators write Windows path separators and line endings into tracked build files and umbrella headers.Use Bash from PATH, launch the Android generator with the current Python interpreter and separate arguments, and normalize generated paths and text output. Android source filtering now also recognizes excluded directories and OpenCL headers when
os.walkreturns Windows paths. Doxygen and header-guard checks preserve LF instead of repeatedly undoing the mixed-line-ending hook. Generated CMake/Bazel files and umbrella headers retain their existing repository contents.Fix the misspelled
grep --exclude_diroptions, which prevented the style scans from running correctly, and batch the license-header scan to avoid launching grep and wc separately for every source file. Since restoring the scans exposes existing missing conditional comments, add the required#else/#endifcomments in 11 source/header files. Those changes were checked against the base to verify that only preprocessor comments changed.The pre-push commit-message hook also installed Commitizen at run time for each filename batch. Concurrent invocations raced while writing to the same environment. Declare Commitizen as an isolated hook dependency and disable filename passing for both commit-message and sign-off checks.
Validation on Windows x64 with Git Bash and Python 3.10.21:
python -m unittest discover -s scripts/tests -v: all 10 tests pass, covering Android filtering, UTF-8/LF output, umbrella includes, graph paths, checkout paths with spaces, and positive/negative style and license checks.pre-commit run: all 14 configured pre-commit hooks pass, including Android, CMake/Bazel generation, style, clang-format, header guards, and repository-wide REUSE compliance.git diff --check: passes; generators leave the tracked build files unchanged.No C++ kernel or API behavior changes; no Arm inference or full C++ library build was run.