Skip to content

Set up Flutter in the publish jobs - #530

Merged
rickdijk merged 1 commit into
mainfrom
fix/publish-needs-flutter-sdk
Sep 16, 2026
Merged

rickdijk merged 1 commit into
mainfrom
fix/publish-needs-flutter-sdk

Conversation

@rickdijk

Copy link
Copy Markdown
Contributor

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix (CI release automation).

⤵️ What is the current behavior?

Both publish jobs install only the Dart SDK via dart-lang/setup-dart, then run dart pub publish. Because both packages depend on flutter from the SDK, dependency resolution fails before anything is uploaded and the step exits 69. The v3.4.3 and firebase-v2.1.4 tags both failed this way; neither package reached pub.dev.

This path was introduced in the (still unreleased) CI modernization, so no previous release exercised it.

The -v flag also made this hard to diagnose: its dependency-resolution dump exceeded the step log limit, so the log was truncated before the actual error.

🆕 What is the new behavior (if this is a feature change)?

The publish jobs set up Flutter with the same pinned FLUTTER_VERSION the other jobs use and publish with flutter pub publish -f. OIDC trusted publishing is unaffected — it relies on the job's id-token: write permission, not on which action installed the SDK. Verbose output is dropped so a future failure is readable.

💥 Does this PR introduce a breaking change?

No.

🐛 Recommendations for testing

Only reachable on a tag push, so PR checks cover the workflow parsing but not the publish step itself. Real verification is re-pointing the v3.4.3 / firebase-v2.1.4 tags at this commit and confirming both packages land on pub.dev. No changelog entry: the existing unreleased "Modernizes GitHub Actions CI" bullet already covers this code, which has never shipped.

📝 Links to relevant issues/docs

Failed runs: v3.4.3, firebase-v2.1.4.

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current main

🤖 Generated with Claude Code

Both publish jobs installed only the Dart SDK, so `dart pub publish` could
not resolve the `flutter` SDK dependency and exited 69 before uploading.
The v3.4.3 and firebase-v2.1.4 tags failed this way and nothing reached
pub.dev.

Uses the same pinned Flutter setup as the other jobs and publishes with
`flutter pub publish`. Drops `-v`, whose output exceeded the step log limit
and truncated the actual error.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@rickdijk
rickdijk merged commit 93ddfef into main Sep 16, 2026
10 checks passed
@rickdijk
rickdijk deleted the fix/publish-needs-flutter-sdk branch September 16, 2026 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant