Conversation
|
Thanks - this may have to sit for a bit while we push the next release out. Will try to get to it soon, thanks. |
83e6165 to
23a6e93
Compare
23a6e93 to
db3bd30
Compare
db3bd30 to
2656c9e
Compare
|
Thanks, looking good. This will need a rebase and testing on v5.5.5 when I push that to master in the next few hours. For the touchscreen change I'll defer to @cateim and @oroderico to review when they get time, to make sure it doesn't break their touchscreen devices. |
2656c9e to
6fbb487
Compare
|
Rebased on master (IDF v5.5.5) and tested again on the hardware |
ESP32-S3 board with a 3.5inch 480x320 capacitive touch display (ST7796/FT6336), OV5640 camera and AXP2101 pmu. The touch controller, the pmu and the camera sccb share the same i2c pins, so the touchscreen owns the only bus on them and both the pmu and the camera attach to it, as done for the T-Display S3 Pro camera. The 3.5B variant uses a different (QSPI) display controller and is not supported.
6fbb487 to
ff6f5ec
Compare
|
I changed how the shared i2c pins are handled: the camera now reuses the touchscreen bus, so the camera.c change only applies to this board and there is nothing to check on other touchscreen devices anymore. Description updated. |
Thanks for the ping @jgriffiths. I don't have the Touch LCD 3.5, so I can't test the board itself, but I checked the current head (ff6f5ec) against master: resolving One heads-up on rolling this into the |
|
Merged with rebase/formatting changes, closing thanks! |
Adds diy support for the Waveshare ESP32-S3-Touch-LCD-3.5 (esp32s3, 480x320 ST7796 display, FT6336 touch, AXP2101 pmu, and an OV5640 camera on the -C version). It follows the existing Touch LCD 2 support, with the same three virtual buttons along the bottom of the screen.
Tested on the hardware: display, touch, QR scanning, brightness, battery level and charging.
On this board the touch controller, the camera sccb and the pmu are all on the same two i2c pins, so the touchscreen owns the only bus on them and the pmu and the camera attach to it (the camera the same way as the T-Display S3 Pro). The camera.c changes only apply to this board.
The 3.5B variant uses a different (QSPI) display controller and is not supported (#243).