Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ausiejute
added
Needs Review
abdishakoor-dev
left a comment
abdishakoor-dev
left a comment
There was a problem hiding this comment.
Nearly there.
What you did well: name, email and size are all validated the way the task asks, the colour radios sit in a fieldset with a legend, the validator is clean and Prettier passes. Tidy commits too, one per section.
One thing to sort before I mark this Complete: on the deploy preview, fill in everything except a colour and press Submit. It goes through. See line 29.
Add the Needs Review label again once you've pushed.
|
|
||
| <fieldset> | ||
| <legend>T-shirt Color</legend> | ||
| <input type="radio" id="blue" name="color" value="B" /> |
There was a problem hiding this comment.
Pick no colour and submit: the form goes through. You've already handled this on the size dropdown on line 41. What's different about these three radios?
There was a problem hiding this comment.
That's it. One required covers the whole group of radios that share the name.
| name="name" | ||
| pattern=".*\S.*\S.*" | ||
| required | ||
| /><br /><br /> |
There was a problem hiding this comment.
Not a blocker: the <br /> tags are only here for spacing. What would you reach for instead of line breaks to control spacing, once the form works?
There was a problem hiding this comment.
Definitely CSS margin or padding
There was a problem hiding this comment.
Yes. Margin or padding in CSS, whenever you next style a form.
abdishakoor-dev
added
Reviewed
ausiejute
added
the
Needs Review
abdishakoor-dev
left a comment
abdishakoor-dev
left a comment
There was a problem hiding this comment.
The form no longer submits without a colour, so all four fields are validated. Nothing left to do, marking this Complete. Well done Diana.
abdishakoor-dev
added
Complete
2 participants
Self checklist
Task Code
CYF-1004
Changelist
I created an HTML form for ordering a T-shirt. It collects the following data: customer's name, email, t-shirt colour and size.