Skip to content

London | 26-ITP-Sep | Diana Ausiejute | Sprint 1 | Form Controls #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ausiejute wants to merge 6 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP-Sep | Diana Ausiejute | Sprint 1 | Form Controls #1523

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
059e6e5
Add t-shirt color picker
Sep 14, 2026
0c159f9
Add name and email sections
Sep 14, 2026
5b80055
Add t-shirt size picker
Sep 14, 2026
73456f8
Add submit button
Sep 14, 2026
94566be
Format the whole document
Sep 14, 2026
22f5729
Add a missing requirement to choose the t-shirt color
Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 41 additions & 7 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en">
<head>
<meta charset="utf-8" />
Expand All @@ -13,15 +13,49 @@ <h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<label for="name"> Name: </label><br />
<input
type="text"
id="name"
name="name"
pattern=".*\S.*\S.*"
required
/><br /><br />

@abdishakoor-dev abdishakoor-dev Sep 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker: the <br /> tags are only here for spacing. What would you reach for instead of line breaks to control spacing, once the form works?

@ausiejute ausiejute Sep 15, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely CSS margin or padding

@abdishakoor-dev abdishakoor-dev Sep 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Margin or padding in CSS, whenever you next style a form.

<label for="email">Email:</label><br />
<input type="email" id="email" name="email" required /><br /><br />

<fieldset>
<legend>T-shirt Color</legend>
<input type="radio" id="blue" name="color" value="B" required />
<label for="blue">Blue</label><br />

<input type="radio" id="green" name="color" value="G" />
<label for="green">Green</label><br />

<input type="radio" id="red" name="color" value="R" />
<label for="red">Red</label>
</fieldset>
<br /><br />

<label for="size">T-Shirt Size:</label>
<select id="size" name="size" required>
<option value="">Select Size</option>
<option value="xs">XS</option>
<option value="s">S</option>
<option value="m">M</option>
<option value="l">L</option>
<option value="xl">XL</option>
<option value="xxl">XXL</option>
</select>
<br />
<br />

<input type="submit" value="Submit" /> <br />
<br />
</form>
</main>
<footer>
<!-- change to your name-->
<p>By HOMEWORK SOLUTION</p>
<p>By Diana Ausiejute</p>
</footer>
</body>
</html>
Loading