fix (WMS): reserve the post-processing margin before advertising the slot - #8746
Merged
Merged
Conversation
aldbr
marked this pull request as draft
August 25, 2026 13:30
aldbr
force-pushed
the
wms-allocated-time-v3
branch
from
September 30, 2026 06:44
5fc3f1c to
9645ee7
Compare
…slot The Watchdog kept StopMargin (300 s by default) at the end of the slot for the uploads, but nothing upstream knew: the Matcher was offered, and elastic payloads sized themselves against, CPU work they would never be allowed to spend. The JobAgent now takes StopMargin off /LocalSite/CPUTimeLeft once, in initialize(), so the CE advertises and the configuration publishes what a payload may actually consume. The PushJobAgent, which builds that figure per queue itself, takes it off in the same way. The Watchdog no longer deducts it a second time: it stops the payload once that published budget is exhausted. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
aldbr
force-pushed
the
wms-allocated-time-v3
branch
from
October 1, 2026 14:18
9645ee7 to
2f2687d
Compare
aldbr
marked this pull request as ready for review
October 1, 2026 14:18
fstagni
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Watchdog kept
StopMargin(300 s by default) at the end of the slot for the uploads, but nothing upstream of it knew: the Matcher was offered, and elastic payloads sized themselves against, CPU work they would never be allowed to spend. Both were then killed withStopMarginstill to go.StopMarginoff/LocalSite/CPUTimeLeftonce, ininitialize(). The CE advertises, and the configuration publishes, what a payload may actually consume.BEGINRELEASENOTES
*WorkloadManagement
FIX: the JobAgent (and PushJobAgent) reserve the JobWrapper's StopMargin before advertising the slot to the Matcher and publishing it in /LocalSite/CPUTimeLeft, so that jobs are neither matched nor sized against time the post-processing will need. The Watchdog no longer deducts it a second time.
ENDRELEASENOTES