Skip to content

Add four passing integration test classes to tests/integration-tests.txt - #12817

Open
ashmanda-cs wants to merge 2 commits into
IQSS:developfrom
uncch-rdmc:12815-add-four-passing-integration-test-classes
Open

ashmanda-cs wants to merge 2 commits into
IQSS:developfrom
uncch-rdmc:12815-add-four-passing-integration-test-classes

Conversation

@ashmanda-cs

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Adds four integration test classes to tests/integration-tests.txt: DataCiteIT, SignedUrlAuthMechanismIT, SiteMapIT and StorageSitesIT. They pass against the CI stack but were never listed, so they never ran. That's 9 more tests in CI for about 10 seconds.

See #12815 for how they were found, and for why IpGroupsIT stays out of the list even though it passes on its own.

Which issue(s) this PR closes:

Special notes for your reviewer:

The only change is one line in tests/integration-tests.txt. The same change was verified in our fork, on top of #12783: run 38064623496 gave 416 integration tests run, 0 failures and 15 skipped in all three jobs (was 407 / 0 / 15).

Suggestions on how to test this:

In the integration test results of this PR's checks, confirm that the four classes ran and passed, and that the totals went from 407 to 416 with 0 failures.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No.

Is there a release notes update needed for this change?:

No. It only changes which existing tests run in CI.

Additional documentation:

None.

DataCiteIT, SignedUrlAuthMechanismIT, SiteMapIT and StorageSitesIT pass
against the CI stack but were never listed, so they never ran.
Copilot AI balanced review requested due to automatic review settings October 10, 2026 16:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@pdurbin

pdurbin commented Oct 13, 2026

Copy link
Copy Markdown
Member

Ideas:

  • Use tags instead
  • Exclusions list instead

@pdurbin pdurbin self-assigned this Oct 13, 2026
@pdurbin pdurbin added the Size: 3 A percentage of a sprint. 2.1 hours. label Oct 13, 2026
@pdurbin pdurbin moved this from Ready for Triage to In Review 🔎 in IQSS Dataverse Project Oct 13, 2026
@poikilotherm

poikilotherm commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

What if we finally replace the ever growing list with a proper Tag "api", enabling using them with a simple mvn verify -Dit.groups=api as we use for integration and performance tests?

Any test not working should be @Disabled or activated by adding another group to the list.

Would require documentation updates as well.

@ashmanda-cs

Copy link
Copy Markdown
Contributor Author

What if we finally replace the ever growing list with a proper Tag "api", enabling using them with a simple mvn verify -Dit.groups=api as we use for integration and performance tests?

Any test not working should be @Disabled or activated by adding another group to the list.

Would require documentation updates as well.

I always loved this idea. Can we open a separate issue to track this?

@pdurbin

pdurbin commented Oct 13, 2026

Copy link
Copy Markdown
Member

Sure, here's a new, separate issue:

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: 3 A percentage of a sprint. 2.1 hours.

Projects

Status: In Review 🔎

Development

Successfully merging this pull request may close these issues.

Add four passing integration test classes to tests/integration-tests.txt

4 participants