Skip to content

skills(agent-tracing): trim skills to what an implementing agent needs - #1174

Merged
JeremyFunk merged 1 commit into
feat/agent-session-instrumentation-docsfrom
skills/agent-tracing-trim
Sep 30, 2026
Merged

JeremyFunk merged 1 commit into
feat/agent-session-instrumentation-docsfrom
skills/agent-tracing-trim

Conversation

@JeremyFunk

@JeremyFunk JeremyFunk commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Stacked on #1115.

  • Cut human-guide links, backend background, tested-version notes, restated code
  • Removed opentelemetry/references/go.md; other languages follow the generic steps
  • Do-not lists: only silent, non-obvious mistakes not already in the steps (230 → 25 items)
  • Genkit: GenkitForMaple processor inlined (verbatim from the guide)
  • OTLP header: quoted literal space everywhere. Checked SDK source: Python exporter ≥1.27 (liberal parsing), JS, Java, .NET, Go all accept a space; every framework pin resolves ≥1.27
  • OpenTelemetry skill framework list: added Cloudflare Agents, Genkit
  • smolagents: enable_genai_semconv=True is required
  • Cost: no change; Maple reads gen_ai.usage.cost then gen_ai.usage.total_cost, so both skills are right

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

- cut human-guide links, backend background, tested-version notes, restated code
- drop the Go reference; other languages follow the generic steps
- Do-not lists keep only silent, non-obvious mistakes not stated in the steps
- inline the GenkitForMaple processor instead of pointing at the guide
- OTLP header: quoted literal space everywhere (every targeted SDK accepts it)
- add Cloudflare Agents and Genkit to the OpenTelemetry skill's framework list
- smolagents: enable_genai_semconv is required
@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 59057dfb-d36f-49e2-a91a-8fec5b07b85d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@maple-review-bot

maple-review-bot Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Maple review

Nothing to review

All 28 changed files are skill markdown docs; no source, infra, config or test files are touched, so there is nothing to review.

What was checked
  • pr_changed_files classified all 28 paths as docs, no source/infra/config/test files left

3a8e204 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

@JeremyFunk
JeremyFunk merged commit 95f945a into feat/agent-session-instrumentation-docs Sep 30, 2026
26 of 27 checks passed
@JeremyFunk
JeremyFunk deleted the skills/agent-tracing-trim branch September 30, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant