fix(effect-sdk): publish against effect rc.118's stable import paths - #1175
JeremyFunk wants to merge 2 commits into
Conversation
…ty paths
rc.118 moved effect/unstable/{http,observability} to effect/{http,observability}
with no aliases, so importing the published SDK threw ERR_MODULE_NOT_FOUND.
The monorepo stays on rc.117, so the source keeps the unstable paths and
prepack rebuilds the tarball with them rewritten; postpack restores the
in-repo build. Peer range moves to >=4.0.0-rc.118.
Maple review🔴 Confidence 2/5 · risky as written Publishes the Effect SDK against rc.118 by rewriting
Findings🟠 Warning · F1 · Peer bump leaves
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe Effect SDK package adds conditional rewriting of unstable Effect import paths during its prepack build. It also runs a postpack build, raises the minimum Effect peer dependency version, and updates the Cloudflare Workers example import. ChangesEffect SDK packaging
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The SDK now targets Effect rc.118 for published imports. No concrete packaging or workspace-install failure is established, so no specific merge blocker is supported. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Maple review🟢 Confidence 5/5 · safe to merge The head commit refreshes
Fixed since the last review
What was checked
|
Effect
4.0.0-rc.118removed everyeffect/unstable/*export (http,observabilityare noweffect/http,effect/observability). The published SDK imports the old paths, so@maple-dev/effect-sdk/serverfails withERR_MODULE_NOT_FOUNDon rc.118 even though the peer range accepts it.The monorepo (and every in-repo SDK consumer) is still on rc.117, where only the unstable paths exist, so the source can't switch yet.
tsdown.config.ts: withMAPLE_EFFECT_STABLE_PATHS=1, arenderChunkplugin rewriteseffect/unstable/*specifiers toeffect/*in.mjsand.d.mtsoutputprepackbuilds with the rewrite;postpackrebuilds normally so the localdist/keeps working for in-repo appseffect→>=4.0.0-rc.118effect/httpConfig.String/Config.Redacted(the other half of the report) were already fixed on main in 0.9.0, which isn't on npm yetVerified:
bun pm packtarball contains onlyeffect/http/effect/observability, peer>=4.0.0-rc.118; localdist/still has unstable paths afterwardsMaple.layerexports a span + logRemove the plugin and scripts once the monorepo moves to rc.118.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit
Compatibility
4.0.0-rc.118.Documentation
effect/httpimport path.