Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an assertion audit against Larastan for custom-builder chains and relation callbacks. It confirms supported behavior through type, completion, diagnostic, and runtime assertions and records five concrete inference gaps as L55–L59 instead of changing the shared engine during the audit.
The new fixture has 35 active type assertions and 20 explicit known-gap expectations using the existing corpus SKIP convention. Laravel demos exercise custom-builder forwarding, dotted relations, and callbacks in later argument positions.
Validation: full cargo test (14,831 passed), both required clippy runs, cargo fmt --check, PHP syntax/runtime checks (185 Laravel assertions), and Laravel analysis with exactly the three intentional diagnostics.
This is the base of a follow-up stack implementing L55–L59, one task per PR.