Skip to content

test(laravel): audit custom builders and relation callbacks - #447

Open
shuvroroy wants to merge 1 commit into
PHPantom-dev:mainfrom
shuvroroy:test/l54-builder-relation-audit
Open

shuvroroy wants to merge 1 commit into
PHPantom-dev:mainfrom
shuvroroy:test/l54-builder-relation-audit

Conversation

@shuvroroy

Copy link
Copy Markdown
Contributor

Adds an assertion audit against Larastan for custom-builder chains and relation callbacks. It confirms supported behavior through type, completion, diagnostic, and runtime assertions and records five concrete inference gaps as L55–L59 instead of changing the shared engine during the audit.

The new fixture has 35 active type assertions and 20 explicit known-gap expectations using the existing corpus SKIP convention. Laravel demos exercise custom-builder forwarding, dotted relations, and callbacks in later argument positions.

Validation: full cargo test (14,831 passed), both required clippy runs, cargo fmt --check, PHP syntax/runtime checks (185 Laravel assertions), and Laravel analysis with exactly the three intentional diagnostics.

This is the base of a follow-up stack implementing L55–L59, one task per PR.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants