Repository navigation
fix(workplace): home shortcuts keep the colleague or room on the meeting form - #567
Merged
Merged
Conversation
…he meeting form "Meeting with a colleague" and "book a favourite room" filled the meeting form on a 300 ms timer. When the form page loaded between 300 and 600 ms after the click, `loadForm` replaced the model with the stored form, and the colleague or room was lost. `EventFormService.newFormWith()` sets the values and saves them with the form at once, so `loadForm` restores them at any load time.
Adding a locker closes the modal. The page object then clicked "confirm selection" if the modal was still visible. When the modal detached first, the click waited its full 20 s, and LOCK-03 and LOCK-04 failed.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two home page shortcuts can open an empty meeting form: "meeting with a colleague" and "book a favourite room".
Each shortcut filled the form on a 300 ms timer. The form service stores the form 300 ms after a change, and the form page calls
loadFormwhen it loads. When the page loaded between 300 and 600 ms after the click,loadFormreplaced the model with the stored form, which did not have the value yet. The colleague or room was lost.The e2e specs
home-meeting-withandhome-favouritesfailed on this in CI (4 failed attempts in the last nine runs).The locker specs
LOCK-03andLOCK-04were also flaky (12 failed attempts in the same runs), for a different reason. Adding a locker closes the modal, but the page object then clicked "confirm selection" if the modal was still visible. When the modal detached first, the click waited its full 20 s.Fix
EventFormService.newFormWith()starts a new form with the given values and saves them with the form at once.loadFormthen restores them at any load time. Both shortcuts use it, and the timers are gone.returnSelectionButtonlocator is removed.Checks
eventsandworkplace. The workplace app builds.Not included
Three other shortcuts use the same timer pattern with the booking form:
landing-upcoming,newBookinginlanding-favourites, andschedule. No spec has failed on them.Changes made by Claude Opus 5.5 in the Claude Code harness.
🤖 Generated with Claude Code