Repository navigation
Monitor modernization + few cleanups and fixes - #131
Merged
Merged
Conversation
…work but untested; minor mismatch of name "probe_estimate" + adds a small test for this
…s continue working
…onitor to store some png results with your datasets wraps around monitor.saveFigures
…fects all engines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Modernizes the reconstruction monitor that every engine uses, and fixes issues found along the way.
MonitorFrameper update tomonitor.update(frame). Cropping and FPM handling moved fromBaseEngineinto the monitor. Existing monitors keep working through the old hooks.tqdm.auto, so they no longer print a line per iteration.reconstruction.saveResults(..., snapshot=monitor)andmonitor.saveFigures()save PNGs of the final figures.DummyMonitorcrashed withTV_autofocuson.NapariMonitorused the wrong layer name.with.Literaltype hints, no more global warning filter.How it was tested
tests/Monitor/tests. The engine regression goldens are unchanged.# %%cells and a GUI window, plus an FPM run, usingexample_scripts/exampleMonitorGUI.py.Notes
None