Skip to content

[hoist_failure] Revise fault-tree lecture and add exercises - #1067

Merged
jstac merged 2 commits into
mainfrom
tom_hoist_failure
Sep 27, 2026
Merged

jstac merged 2 commits into
mainfrom
tom_hoist_failure

Conversation

@jstac

@jstac jstac commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Revisions by @thomassargent30 to hoist_failure:

  • treats the three lognormal components as i.i.d.; reframes the direct vs FFT convolution timing
  • compares computed percentiles with Table 11 of Greenfield and Sargent (1993) and the DOE 1990 point estimate; new "Reading the answer" section
  • converts exercise-start/end blocks to exercise and adds further exercises

No new bib entries.

Split out of tom_mfg (commit 8bf3b2c) so each lecture can be reviewed separately. Content is unchanged from Tom's commit; only the relevant quant-econ.bib entries and _toc.yml lines are included here.

Merge order: independent — can be merged at any time, in any order relative to the other split PRs (#1067, #1068, #1069, #1070/#1071). Each PR adds its bib entries at a different place in quant-econ.bib, so they do not conflict.

🤖 Generated with Claude Code

…rgent (1993), add exercises

Split out of branch tom_mfg (commit 8bf3b2c).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jstac

jstac commented Sep 26, 2026

Copy link
Copy Markdown
Contributor Author

TODO before merge: check this lecture against the QuantEcon style guide (writing, code, math, figures, references, doc links, admonitions).

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

📖 Netlify Preview Ready!

Preview URL: https://pr-1067--sunny-cactus-210e3e.netlify.app

Commit: 32910ad

📚 Changed Lectures


Build Info

- Replace hard-coded speed claims with qualitative wording, and drop the
  convolution-vs-simulation speed comparison in the hoist_ex4 solution,
  which runs the other way (~2 s for the 13 convolutions vs ~0.2 s for
  10^6 draws)
- One sentence per paragraph in the hoist_ex1 solution
- Italic rather than bold for emphasis
- \Pr(...) -> \mathbb{P}\{...\}, and "i.i.d." -> "IID"
- Sentence case for the fast Fourier transform heading and its
  mid-sentence use

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@mmcky

mmcky commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

@jstac Style guide check done ✅ Nice set of new exercises!

The lecture was already in good shape ({cite:t}, ipython3 cells, a captioned new figure, default_rng, qe.Timer), so I've pushed one small commit (32910ad) with the remaining fixes:

  • Timing claims in prose: the style guide prefers qualitative wording to hard-coded speeds, so "slower by more than two orders of magnitude" now reads "far slower still". In the hoist_ex4 solution I dropped "far quicker … a couple of seconds", since the comparison actually runs the other way (~2 s for the 13 convolutions vs ~0.2 s for 10⁶ draws on my laptop). The point about reproducibility stays.
  • One sentence per paragraph in the hoist_ex1 solution.
  • Italic for emphasis, bold for definitions: stops, spacing, far tail, overall precision.
  • Notation: \Pr(…) → \mathbb{P}\{…\} (3 places) and "i.i.d." → "IID".
  • Sentence case for the "fast Fourier transform" heading and its mid-sentence use.

Nothing changes the substance. Happy to adjust anything.

@jstac

jstac commented Sep 27, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @mmcky @thomassargent30 . Merging.

@jstac
jstac merged commit 919d909 into main Sep 27, 2026
2 checks passed
@jstac
jstac deleted the tom_hoist_failure branch September 27, 2026 05:44
@mmcky

mmcky commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

✅ Translation sync completed (zh-cn)

Target repo: QuantEcon/lecture-python.zh-cn
Translation PR: QuantEcon/lecture-python.zh-cn#285
Files synced (1):

  • lectures/hoist_failure.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants