ci: run pull-request checks only when ci-full is applied - #1773
Merged
Merged
Conversation
GitHub creates and queues a workflow run before it evaluates job-level `if`. After agents marked a swarm ready, 80 CI runs sat ahead of release publish even though earlier draft guards had kept their jobs light. Pull-request CI, plugin validation, and SDK conformance now trigger only on a label event and run only when that event applies ci-full. Opening, pushing, and marking ready create no run. Remove and re-add ci-full after a new push to test that head; ci-os, ci-hosts, and perf still extend that dispatch.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why #1744 was insufficient
GitHub creates/queues the workflow run before evaluating job-level
if. The 130-PR swarm later marked many drafts ready; at 10:00 there were 173 open PRs and 80 queued CI runs ahead of beta.45publish, even though no runner was active. A skipped-job policy cannot prevent the run queue itself.On-demand PR policy
CI,Plugin Validation, andSDK conformancepull-request triggers aretypes: [labeled]only.ci-full.ci-fullto test the current head. After another push, remove and re-add it to test the new head.ci-os,ci-hosts, andperfstill extend that explicit dispatch.This is the only GitHub-native way to prevent untrusted/unbounded PR volume from occupying the run FIFO; job-level conditions are too late.
CONTRIBUTING.mdupdated.actionlint, release safety, and Rust cache-lineage guards pass.