RC-350 Unify ruling expectation file locations. - #6103
Conversation
7ca009e to
caa2455
Compare
This comment has been minimized.
This comment has been minimized.
|
❌ Ruling needs updating. A fix PR has been created: #6170 Please review and merge it into your branch. |
Ruling Diff SummaryDetected changes in 1252 rule files: 0 issues removed, 164136 issues added. S103 (
|
|
❌ Ruling needs updating. A fix PR has been created: #6177 Please review and merge it into your branch. |
|
❌ Ruling needs updating. A fix PR has been created: #6180 Please review and merge it into your branch. |
|
❌ Ruling needs updating. A fix PR has been created: #6204 Please review and merge it into your branch. |
|
❌ Ruling needs updating. A fix PR has been created: #6207 Please review and merge it into your branch. |
2 similar comments
|
❌ Ruling needs updating. A fix PR has been created: #6207 Please review and merge it into your branch. |
|
❌ Ruling needs updating. A fix PR has been created: #6207 Please review and merge it into your branch. |
Move ruling expectation JSON files from its/ruling/src/test/resources/<project>/ to its/ruling/src/test/resources/expected/java/<project>/ for consistency across analyzers. Update JavaRulingTest to read expectations from the new path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…y structure Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…erences Remove duplicated ruling expectation directories that were left at its/ruling/src/test/resources/<project>/ after the move to expected/java/<project>/. Also update the upload-actual expected-dir in CI and the README instructions to reference the new path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
26a1432 to
e15d5db
Compare
Co-authored-by: Romain Brenguier <11854194+romainbrenguier@users.noreply.github.com>
|
Minor finding: AGENTS.md line 264 still documents the old ruling expectation path ( |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Code Review ✅ Approved 4 closed / 4 findings🟡 Medium risk · Ruling tests and CI now resolve 1,257 baselines from a new directory. Normalizes ruling expectation file locations to ✅ 4 closed✅ Bug: CI ruling-root inputs still point at the old expectation root
✅ Bug: Master's new ruling files still land at the old path and are left behind on merge
✅ Quality: PR description names expected/java/<project>/, but the code uses expected/<project>/
✅ Quality: Docs still point at expected/java/ and old per-project ruling paths
Review coverage🧪 Functional validation No results 📋 Rules No rules evaluated 🤖 Auto-approval Not enabled · Set up OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|





Summary
Normalize ruling expectation file locations so that it is consistent across all analyzers.
its/ruling/src/test/resources/<project>/toits/ruling/src/test/resources/expected/<project>/JavaRulingTestto read expectations from the new pathTest plan
🤖 Generated with Claude Code
Agent workflow
Tool link: Tool link: https://github.com/SonarSource/languages-experimental-tooling/tree/romain/my-tickets/personal/romain-brenguier
Iterated on the PR with
uv run ci_loop.pyfor 4 iterations.✔️ The PR is now ready for review.
Iterated on the PR with
uv run ci_loop.pyfor 0 iterations.✔️ The PR is now ready for review.
Iterated on the PR with
uv run ci_loop.pyfor 0 iterations.✔️ The PR is now ready for review.