RC-350 Unify ruling expectation file locations.

.github/workflows/build.yml

@@ -128,7 +128,7 @@ jobs:
         with:
           name: ${{ matrix.item.runner }}_${{ matrix.item.profile }}
           it-dir: its/ruling
-          expected-dir: src/test/resources
+          expected-dir: src/test/resources/expected
           actual-dir: target/actual
 
   ruling-update-notify:
@@ -168,7 +168,7 @@ jobs:
         with:
           pr-number: ${{ github.event.pull_request.number }}
           ruling-failed: ${{ steps.check-ruling.outputs.ruling-failed }}
-          ruling-root: 'its/ruling/src/test/resources'
+          ruling-root: 'its/ruling/src/test/resources/expected'
           sources-root: 'its/sources'
         env:
           GH_TOKEN: ${{ github.token }}

.github/workflows/ruling-diff-comment.yml

@@ -53,7 +53,7 @@ jobs:
           repository: ${{ github.repository }}
           base-sha: ${{ inputs.base-sha || github.event.pull_request.base.sha }}
           head-sha: ${{ inputs.head-sha || github.event.pull_request.head.sha }}
-          ruling-root: 'its/ruling/src/test/resources'
+          ruling-root: 'its/ruling/src/test/resources/expected'
           sources-root: 'its/sources'
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

AGENTS.md

@@ -261,7 +261,7 @@ str="<line including <substring>>"; sub="<substring>"; pre="${str%%"$sub"*}" suf
 
 Ruling tests validate that rule fixes don't break existing true positives. They run the analyzer against real-world Java projects (`guava`, `commons-beanutils`, `eclipse-jetty`, `sonar-server`, `jboss-ejb3-tutorial`, `regex-examples`) and compare results to expected baselines.
 
-- Expected ruling files: `its/ruling/src/test/resources/<project>/java-<RULE_ID>.json`
+- Expected ruling files: `its/ruling/src/test/resources/expected/<project>/java-<RULE_ID>.json`
 - Actual ruling output: `its/ruling/target/actual/<project>/java-<RULE_ID>.json`
 - Format: `{"group:artifact:path/to/File.java": [line1, line2, ...], ...}`
 - Ruling sources: `its/sources/<project>/`

README.md

@@ -168,11 +168,11 @@ All the `json` files contain a list of lines, indexed by file, explaining where
 
 Into the directory with the expected issues:
 
-    its/ruling/src/test/resources/
+    its/ruling/src/test/resources/expected/
 
 For example using the command:
 
-    cp its/ruling/target/actual/* its/ruling/src/test/resources/
+    cp its/ruling/target/actual/* its/ruling/src/test/resources/expected/
 
 #### Debugging Integration Tests
 You can debug ITs by adding `-Dmaven.binary=mvnDebug` as an option when running the tests. This will cause the analyzer JVM to wait for a debugger to be attached before continuing.

its/ruling/src/test/java/org/sonar/java/it/JavaRulingTest.java

@@ -157,7 +157,7 @@ public static void afterAllAnalysis() throws IOException {
   }
 
   private static void prepareDumpOldFolder() throws Exception {
-    Path allRulesFolder = Paths.get("src/test/resources");
+    Path allRulesFolder = Paths.get("src/test/resources/expected");
     if (SUBSET_OF_ENABLED_RULES.isEmpty()) {
       effectiveDumpOldFolder = allRulesFolder.toAbsolutePath();
     } else {