cks: set CDROM volume label when building the binaries ISO - #14182
Open
kiranchavala wants to merge 1 commit into
Open
kiranchavala wants to merge 1 commit into
kiranchavala wants to merge 1 commit into
Conversation
The CKS nodes locate the binaries ISO purely by its ISO 9660 volume label: output=`blkid -o device -t LABEL=CDROM` (conf/k8s-control-node.yml) but create-kubernetes-binaries-iso.sh invoked mkisofs without -V, relying on the tool's default volume ID. That default is not portable: genisoimage / cdrkit (Debian, Ubuntu) -> CDROM xorriso mkisofs compat mode (EL8+) -> ISOIMAGE genisoimage has not been available since EL8, where mkisofs is provided by xorriso, so an ISO built on EL8/EL9/EL10 gets LABEL="ISOIMAGE". The nodes then never mount it, loop on "Waiting for Binaries directory /mnt/k8sdisk/ to be available" until the offline install times out, and silently fall through to installing from the Internet instead of using the pinned ISO contents. Pass -V CDROM explicitly so the output no longer depends on which ISO tool the build host happens to provide. This is a no-op on hosts where the script works today, since CDROM is already the genisoimage default. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #14182 +/- ##
=========================================
Coverage 16.38% 16.38%
- Complexity 13614 13616 +2
=========================================
Files 5669 5669
Lines 501532 501532
Branches 60922 60922
=========================================
+ Hits 82153 82180 +27
+ Misses 410172 410143 -29
- Partials 9207 9209 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #14180
How Has This Been Tested?
Reproduced on an Oracle Linux 8 build host (
xorriso 1.4.8, nogenisoimageavailable on EL8) building a CKS ISO for Kubernetes 1.36.0.Before the change, the ISO is built successfully but carries the wrong label:
after change