Skip to content

cks: set CDROM volume label when building the binaries ISO #14182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kiranchavala wants to merge 1 commit into
base: 4.20
Choose a base branch
from
Open

cks: set CDROM volume label when building the binaries ISO #14182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion scripts/util/create-kubernetes-binaries-iso.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,10 @@ chmod ${kubeadm_file_permissions} "${working_dir}/k8s/kubeadm"
echo "Updating imagePullPolicy to IfNotPresent in yaml files..."
sed -i "s/imagePullPolicy:.*/imagePullPolicy: IfNotPresent/g" ${working_dir}/*.yaml

mkisofs -o "${output_dir}/${build_name}" -J -R -l "${iso_dir}"
# The volume label must be CDROM: the CKS nodes locate this ISO with
# "blkid -o device -t LABEL=CDROM" (see conf/k8s-control-node.yml). Do not rely on the
# tool default -- genisoimage defaults to CDROM but xorriso's mkisofs compatibility mode
# (the only mkisofs available on EL8+) defaults to ISOIMAGE, which the nodes never find.
mkisofs -V CDROM -o "${output_dir}/${build_name}" -J -R -l "${iso_dir}"

rm -rf "${iso_dir}"
Loading