chore(deps): quitar uuid muerto, no proponer majors de @nestjs/* y re-observar la evidencia de madurez - #723
Merged
Conversation
… @nestjs/* Triaje de PRs abiertos (2026-09-19): - `uuid` y `@types/uuid` estaban declarados en `src/packages/mcp-server` sin un solo import en todo `src/`. Dependabot proponía subirlos tres majors (#718); lo correcto es quitarlos. - NestJS 12 es ESM-only y hay que migrarlo en bloque; los bumps por paquete (#720 core, #721 platform-express) rompían jest en los 5 workspaces. Se ignoran los majors de `@nestjs/*` hasta que la migración se haga a mano. - De paso npm normaliza en el lock el rango de `@opentelemetry/exporter-trace-otlp-http` de mcp-server y cli a la versión fija que declaran sus package.json (Dependabot escribió `^`). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
📊 Bilingual Coverage ImpactPR Changes
Repository Coverage
✅ Good: All EN changes have ES counterparts. Generated by GitHub Actions |
…ged out again The four entries were taken together on 2026-08-18 and all four crossed the 0..30 day window of `09-reconcile-maturity.mjs` on 2026-09-18, so `Validate documentation` went red on #722 and #723 -- two Dependabot-adjacent PRs whose content has nothing to do with it. As last time, the window is the point: each entry is a fresh observation of the same claim against a real green run, not a date bump. - cli-baseline: run 35435224907 on main (99b5325), all THIRTEEN CLI CI jobs green, CI Gate included. - coverage: same run, Unit Tests -- 107 suites / 1492 tests, Statements 87.22%, Lines 87.54%, Functions 84.79%, Branches 75.73% (2382/3145) against the unchanged jest thresholds (80/80/75/75) and the workflow statement gate (80). All three totals grew since 2026-08-18 (106 / 1486 / 2376/3139). - documentation: run 35125943994 on 3d0662c (head of #719, merged into main as 99b5325 with no other change), both jobs green. It cites a run from 2026-09-16 on purpose: after the window closed, every later run of this workflow is red AT the reconcile step because of the window itself, so the last green run before it closed is the only honest observation of this claim until this refresh lands. - release: run 35435224976 on main (99b5325), green through package-binaries and smoke-test on all three platforms plus smoke-test-functional; publish/upload skipped because it is not a `cli-v*` tag. `maturity-reconciliation.json` is regenerated from the evidence (it embeds `readiness`); `asOf` stays at 2026-09-05 because the gap board did not move, so the executive summary is unchanged (`generate-executive-summary.mjs --check` passes). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
beyondnetPeru
deleted the
chore/prune-dead-uuid-and-nest-major-ignore
branch
September 19, 2026 10:35
beyondnetPeru
added a commit
that referenced
this pull request
Sep 19, 2026
main moved under the promotion: #723 (uuid pruned from mcp-server, @nestjs/* majors ignored in dependabot.yml) landed on main directly and carried a THIRD refresh of the same aged-out maturity evidence (20706cd). Conflict on the two evidence files only; develop's refresh (2ee3f9a, already on this branch) is kept — every commit it cites is reachable once main is merged in — and 09-reconcile-maturity --check plus guard 46 pass on the result. #723's own changes come through untouched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Sep 19, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
Salida del triaje de los 5 PRs abiertos de Dependabot (2026-09-19):
uuidy@types/uuiddesrc/packages/mcp-server. Estaban declarados sin un soloimport/requireen todosrc/. chore(deps): bump uuid from 11.1.1 to 14.0.2 #718 (uuid 11→14) se cerró: no tiene sentido subir tres majors a una dependencia muerta.dependabot.yml: ignora los majors de@nestjs/*. NestJS 12 es ESM-only (type: module) y hay que migrarlo en bloque (todo@nestjs/*+ jest/ts config). chore(deps): bump @nestjs/core from 11.2.1 to 12.0.1 #720 y chore(deps): bump @nestjs/platform-express from 11.1.28 to 12.0.1 #721 (core y platform-express por separado) rompían jest en los 5 workspaces y se cerraron. Cuando se haga la migración a mano se retira la regla.@opentelemetry/exporter-trace-otlp-httpde mcp-server y cli (^0.222.0→0.222.0) para que case con la versión fija de suspackage.json.Y además: la evidencia de madurez había caducado (segundo commit)
Las cuatro entradas de
maturity-evidence.jsonse tomaron el 2026-08-18 y cruzaron la ventana 0..30 días de09-reconcile-maturity.mjsel 2026-09-18, así queValidate documentation(check requerido) estaba rojo en todo PR, este y #722 incluidos, sin relación con su contenido. Igual que en 3e5aac8: se re-observan las cuatro contra corridas verdes reales, no se mueve la fecha.99b5325999b532593d0662c7(head de #719)99b53259asOfno se toca (el board no se movió), así que el executive summary no cambia;maturity-reconciliation.jsonse regenera.Verificación
grepde imports deuuidensrc/: 0 resultados.npm uninstall --package-lock-only; el diff son las dos entradas de uuid + la normalización del rango.09-reconcile-maturity.mjs+--check,08-validate-tracking.mjs,generate-executive-summary.mjs --checken verde.🤖 Generated with Claude Code