Skip to content

test: update tests left pointing at the removed browser - #404

Merged
arzafran merged 1 commit into
mainfrom
fix/post-browser-removal-tests
Oct 7, 2026
Merged

arzafran merged 1 commit into
mainfrom
fix/post-browser-removal-tests

Conversation

@arzafran

@arzafran arzafran commented Oct 7, 2026

Copy link
Copy Markdown
Member

What this does

Turns main CI green again after #403. The app was fine; three tests still expected the removed browser.

  • Bonsplit package tests used the removed "New Browser" split tooltip and the reload tab action. They no longer compiled, which stopped unit-test shard 2 before it ran anything.
  • test_mcp_server_e2e.py hard-coded 13 focus_ tools. There are 10 now that the three focus_browser_* tools are gone; the count now follows the expected-name set the test already checks.
  • testAttachedTransferIgnoresStaleFinalizeAndNextDetachHasIndependentOwnership expected a finalized terminal to stop at closing. Closing a terminal panel tears its surface down right away, so the state is closed. The assertion was new in refactor: remove the built-in browser #403 and never ran.

Test plan

Local: Bonsplit tests compile with swift build --build-tests. No tests run locally.

@arzafran
arzafran merged commit f6e560c into main Oct 7, 2026
13 checks passed
@arzafran
arzafran deleted the fix/post-browser-removal-tests branch October 7, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant