Skip to content

test: update tests left pointing at the removed browser #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arzafran merged 1 commit into from
Oct 7, 2026
Merged

test: update tests left pointing at the removed browser #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion programaTests/WorkspaceUnitTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3970,7 +3970,7 @@ final class WorkspacePanelGitBranchTests: XCTestCase {
let nextTransfer = try XCTUnwrap(destination.detachSurface(panelId: terminalPanel.id))
XCTAssertFalse(nextTransfer === transfer, "A later detach must have a new pending lifecycle owner")
nextTransfer.finalizePermanently()
XCTAssertEqual(terminalPanel.surface.portalBindingStateLabel(), "closing")
XCTAssertEqual(terminalPanel.surface.portalBindingStateLabel(), "closed")
}


Expand Down
2 changes: 1 addition & 1 deletion tests_v2/test_mcp_server_e2e.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ def _assert_tools_list_matches_exact_catalog(mcp: ProgramaMcpClient) -> None:
focus_names == EXPECTED_FOCUS_TOOL_NAMES,
f"focus_-prefixed tool set drifted -- expected {sorted(EXPECTED_FOCUS_TOOL_NAMES)}, got {sorted(focus_names)}",
)
_must(len(focus_names) == 13, f"expected exactly 13 focus_-prefixed tools, got {len(focus_names)}")
_must(len(focus_names) == len(EXPECTED_FOCUS_TOOL_NAMES), f"expected exactly {len(EXPECTED_FOCUS_TOOL_NAMES)} focus_-prefixed tools, got {len(focus_names)}")

_must(all("." not in name for name in actual_names), f"tool names must never contain '.': {[n for n in actual_names if '.' in n]}")

Expand Down
8 changes: 3 additions & 5 deletions vendor/bonsplit/Tests/BonsplitTests/BonsplitTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,6 @@ final class BonsplitTests: XCTestCase {
func testDefaultSplitButtonTooltips() {
let defaults = BonsplitConfiguration.SplitButtonTooltips.default
XCTAssertEqual(defaults.newTerminal, "New Terminal")
XCTAssertEqual(defaults.newBrowser, "New Browser")
XCTAssertEqual(defaults.splitRight, "Split Right")
XCTAssertEqual(defaults.splitDown, "Split Down")
}
Expand All @@ -202,7 +201,6 @@ final class BonsplitTests: XCTestCase {
func testConfigurationAcceptsCustomSplitButtonTooltips() {
let customTooltips = BonsplitConfiguration.SplitButtonTooltips(
newTerminal: "Terminal (⌘T)",
newBrowser: "Browser (⌘⇧L)",
splitRight: "Split Right (⌘D)",
splitDown: "Split Down (⌘⇧D)"
)
Expand Down Expand Up @@ -495,13 +493,13 @@ final class BonsplitTests: XCTestCase {
func testRequestTabContextActionForwardsToDelegate() {
let controller = BonsplitController()
let pane = controller.focusedPaneId!
let tabId = controller.createTab(title: "Test", kind: "browser")!
let tabId = controller.createTab(title: "Test", kind: "terminal")!
let spy = TabContextActionDelegateSpy()
controller.delegate = spy

controller.requestTabContextAction(.reload, for: tabId, inPane: pane)
controller.requestTabContextAction(.rename, for: tabId, inPane: pane)

XCTAssertEqual(spy.action, .reload)
XCTAssertEqual(spy.action, .rename)
XCTAssertEqual(spy.tabId, tabId)
XCTAssertEqual(spy.paneId, pane)
}
Expand Down
Loading