Fix and simplify Maven Central credentials - #3086
Merged
Merged
Conversation
Goooler
force-pushed
the
g/20260916/fix-snapshots
branch
6 times, most recently
from
September 16, 2026 13:30
137b4e4 to
c6ae457
Compare
Goooler
commented
Sep 16, 2026
nedtwigg
reviewed
Sep 16, 2026
Goooler
force-pushed
the
g/20260916/fix-snapshots
branch
3 times, most recently
from
September 17, 2026 16:28
d7ef83d to
14bdd87
Compare
Goooler
force-pushed
the
g/20260916/fix-snapshots
branch
from
September 17, 2026 16:49
e7b893a to
b667bcb
Compare
Goooler
marked this pull request as ready for review
September 17, 2026 16:49
Goooler
commented
Sep 17, 2026
Comment on lines
-82
to
-88
| create("spotlessPluginLegacy") { | ||
| id = "com.diffplug.gradle.spotless" | ||
| implementationClass = "com.diffplug.gradle.spotless.SpotlessPluginRedirect" | ||
| displayName = "Spotless formatting plugin (legacy)" | ||
| description = project.description | ||
| tags = listOf("format") | ||
| } |
Member
Author
There was a problem hiding this comment.
I recalled there is no need for publishing the legacy plugin, just declare it as the history item in b667bcb. Copied from https://github.com/GradleUp/shadow/blob/35b7a3db0f0d9fa795c8e34557a8dd23e0edf2ac/build.gradle.kts#L93-L108
Member
Author
|
There should be no blockers left for the new release now. Please check and test the release with RCs before the final GA. |
Member
|
Will do! Thanks for this wonderful cleanup - I'm excited for the renovate PRs to "just work" |
nedtwigg
enabled auto-merge
September 17, 2026 17:01
This was referenced Sep 17, 2026
Open
dayanruben
pushed a commit
to dayanruben/spotless
that referenced
this pull request
Sep 18, 2026
diffplug#3086 stopped publishing the marker for the legacy `com.diffplug.gradle.spotless` id and added a historical capability, both of which can break a consumer's build. Neither was in the changelog. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to fix https://github.com/diffplug/spotless/actions/runs/35094628080/job/104794839433