Repository navigation
Remove JsonSchema.NET - #7785
Merged
rosebyte merged 1 commit intoOct 13, 2026
Merged
Conversation
rosebyte
enabled auto-merge (squash)
October 13, 2026 08:45
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7785 +/- ##
==========================================
- Coverage 70.26% 69.95% -0.31%
==========================================
Files 1419 1419
Lines 272603 272603
Branches 27940 27562 -378
==========================================
- Hits 191544 190703 -841
- Misses 73643 73706 +63
- Partials 7416 8194 +778
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
matouskozak
approved these changes
Oct 13, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The dependency removal is complete, consistent, and leaves no remaining references.
0 open findings
What changed in this PR
Removes the unused JsonSchema.NET dependency from ML.NET samples and central package management.
Changes:
- Removes the samples project package reference.
- Removes the central package declaration and version property.
| File | Description |
|---|---|
eng/Versions.props |
Removes the unused version property. |
Directory.Packages.props |
Removes central package registration. |
docs/samples/Microsoft.ML.Samples/Microsoft.ML.Samples.csproj |
Removes the package reference. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unused
JsonSchema.Netreference fromMicrosoft.ML.Samples, together with its central package declaration inDirectory.Packages.propsand version property ineng/Versions.props.Removing the reference also drops
JsonPointer.Net,Json.More.NetandHumanizer.Corefrom the samples’ dependency graph.Rationale
The former GenAI consumers were removed in dotnet/machinelearning#7738. The samples project was the only remaining consumer and does not use the package’s APIs. No replacement implementation is needed.