Fix sporadic NPE if code-mining provider has been disposed #4392 - #4393
Merged
Merged
Conversation
…atform#4392 The code mining provider might be notified _after_ it has already been disposed and as such might access a preference store or a document which no longer exists. This change adds additional null-checks to make sure that in such a situation, an empty list of code-minings is returned. Closes eclipse-platform#4392
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code mining provider might be notified after it has already been disposed and as such might access a preference store or a document which no longer exists.
This change adds additional null-checks to make sure that in such a situation, an empty list of code-minings is returned.
Closes #4392