Skip to content

Fix sporadic NPE if code-mining provider has been disposed #4392 #4393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BeckerWdf merged 1 commit into from
Sep 21, 2026
Merged

Fix sporadic NPE if code-mining provider has been disposed #4392 #4393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions ...e/ui/internal/texteditor/codemining/ZeroWidthCharactersLineContentCodeMiningProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2025 SAP S.E. and others.
* Copyright (c) 2025, 2026 SAP S.E. and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -28,6 +28,7 @@
import org.eclipse.jface.util.IPropertyChangeListener;
import org.eclipse.jface.util.PropertyChangeEvent;

import org.eclipse.jface.text.IDocument;
import org.eclipse.jface.text.ITextViewer;
import org.eclipse.jface.text.codemining.AbstractCodeMiningProvider;
import org.eclipse.jface.text.codemining.ICodeMining;
Expand Down Expand Up @@ -64,8 +65,13 @@ public CompletableFuture<List<? extends ICodeMining>> provideCodeMinings(ITextVi
return CompletableFuture.completedFuture(Collections.emptyList());
}

IDocument document = viewer.getDocument();
if (document == null) {
return CompletableFuture.completedFuture(Collections.emptyList());
}

List<ICodeMining> list = new ArrayList<>();
String content = viewer.getDocument().get();
String content = document.get();
for (int i = 0; i < content.length(); i++) {
boolean isZwCharacter = ZW_CHARACTERS.contains(content.charAt(i));
if (isZwCharacter) {
Expand Down Expand Up @@ -102,8 +108,10 @@ public void dispose() {

private void loadStoreAndReadProperty() {
store = getAdapter(IPreferenceStore.class);
readShowZwspFromStore();
store.addPropertyChangeListener(this);
if (store != null) {
readShowZwspFromStore();
store.addPropertyChangeListener(this);
}
}

private ICodeMining createCodeMining(int offset) {
Expand Down
Loading