Repository navigation
Run SafeRunnableErrorTest's other-thread case on another thread - #4455
Merged
vogella merged 1 commit intoOct 8, 2026
Merged
Conversation
testSafeRunnableHandlerOtherThread called Thread.run() instead of start(), so the runnable ran on the UI thread like the other tests and the non-UI code path was never exercised. The thread is now started, the test checks that the runnable ran without an exception escaping the thread, and it processes the error dialog that the workbench posts asynchronously from that thread. Assisted-by: multiple AI agents and layers of automated tooling 🤖
vogella
force-pushed
the
lv/saferunnable-other-thread
branch
from
October 8, 2026 07:55
9377aeb to
519e03e
Compare
Contributor
Member
|
This PR caused test fail today on all platforms, like: https://download.eclipse.org/eclipse/downloads/drops4/I20261008-2300/testresults/html/org.eclipse.jface.tests_ep442I-unit-linux-x86_64-java25_linux.gtk.x86_64_25.html |
Contributor
Author
|
I have a look |
Contributor
Author
|
Existing code which causes that, only before my change, the test never processed events, so it never touched PlatformUI. I push a PR soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testSafeRunnableHandlerOtherThread called Thread.run() instead of start(), so its runnable ran on the UI thread and the test covered nothing beyond testSafeRunnableHandler. It now starts the thread, asserts that the thread finished without an exception escaping and that the runnable ran once, and processes the error dialog that the workbench posts with asyncExec from a non-UI thread, so the dialog does not surface in a later test.