Skip to content

Add exists() and isDirectory() methods to IFileStore - #2951

Merged
HannesWell merged 1 commit into
eclipse-platform:masterfrom
HannesWell:filestore-convenience-methods
Sep 21, 2026
Merged

HannesWell merged 1 commit into
eclipse-platform:masterfrom
HannesWell:filestore-convenience-methods

Conversation

@HannesWell

Copy link
Copy Markdown
Member

Add the methods IFileStore.exists() and IFileStore.isDirectory() methods.

The new methods make the corresponding methods more convenient to use and allow subsequent optimizations of their implementation.

There are further potential callers in the eclipse.platform.ui, JDT and PDE repositories.

@eclipse-platform-bot

Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

resources/examples/org.eclipse.ui.examples.filesystem/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 9b3ba1f855314a76f3bf600edc65509cb5581605 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Sat, 19 Sep 2026 12:47:39 +0000
Subject: [PATCH] Version bump(s) for 4.42 stream


diff --git a/resources/examples/org.eclipse.ui.examples.filesystem/META-INF/MANIFEST.MF b/resources/examples/org.eclipse.ui.examples.filesystem/META-INF/MANIFEST.MF
index 325dc32f3e..b2a8ed32f2 100644
--- a/resources/examples/org.eclipse.ui.examples.filesystem/META-INF/MANIFEST.MF
+++ b/resources/examples/org.eclipse.ui.examples.filesystem/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Bundle-ManifestVersion: 2
 Automatic-Module-Name: org.eclipse.ui.examples.filesystem
 Bundle-Name: Efs Examples Plug-in
 Bundle-SymbolicName: org.eclipse.ui.examples.filesystem;singleton:=true
-Bundle-Version: 1.2.100.qualifier
+Bundle-Version: 1.2.200.qualifier
 Bundle-Vendor: Eclipse.org
 Require-Bundle: org.eclipse.core.filesystem,
  org.eclipse.core.resources,
-- 
2.55.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions

github-actions Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Test Results

    54 files  ±0      54 suites  ±0   57m 21s ⏱️ - 1m 47s
 4 811 tests ±0   4 789 ✅ ±0   22 💤 ±0  0 ❌ ±0 
12 324 runs  ±0  12 171 ✅ ±0  153 💤 ±0  0 ❌ ±0 

Results for commit af4c9cc. ± Comparison against base commit 14321ba.

♻️ This comment has been updated with latest results.

The new methods make the corresponding methods more convenient to use
and allow subsequent optimizations of their implementation.
@HannesWell
HannesWell force-pushed the filestore-convenience-methods branch from 1ee814b to af4c9cc Compare September 21, 2026 17:47
@HannesWell
HannesWell merged commit 337a482 into eclipse-platform:master Sep 21, 2026
18 checks passed
@HannesWell
HannesWell deleted the filestore-convenience-methods branch September 21, 2026 18:33
HannesWell added a commit to HannesWell/eclipse.platform.ui that referenced this pull request Sep 22, 2026
HannesWell added a commit to HannesWell/eclipse.jdt.ui that referenced this pull request Sep 23, 2026
HannesWell added a commit to HannesWell/eclipse.platform.ui that referenced this pull request Sep 23, 2026
akurtakov pushed a commit to eclipse-jdt/eclipse.jdt.ui that referenced this pull request Sep 23, 2026
HannesWell added a commit to eclipse-platform/eclipse.platform.ui that referenced this pull request Sep 23, 2026
HannesWell added a commit to eclipse-pde/eclipse.pde that referenced this pull request Sep 24, 2026
HannesWell added a commit to eclipse-pde/eclipse.pde that referenced this pull request Sep 25, 2026
HannesWell added a commit to eclipse-pde/eclipse.pde that referenced this pull request Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants