Repository navigation
docs: update CLAUDE.md and AUDIO.md to match current code - #143
Merged
aviv1ron1 merged 2 commits intoOct 11, 2026
Merged
Conversation
samadarsh
requested review from
antonpibm,
aviv1ron1,
freunda and
yairallouche
as code owners
October 9, 2026 10:41
CLAUDE.md still described the removed SingleSwitch: the project tree listed hf/switch/single.py and vllm/switch/single.py, the import example and test commands pointed at SingleSwitch files that no longer exist, and the architecture section described a trainable router. It now reflects the coded-memory MultiSwitch (the only engine since generative-computing#131), links docs/MULTISWITCH_EXPLAINED.md, and lists conversation.py, token_exchange.py, hf/switch/codes/, vllm/audio/ and tests/audio/. The dev install command used `--extra dev`, but `dev` is a dependency group, so it is now `--group dev`; the nonexistent tests/regression/ entry is dropped. docs/AUDIO.md said transformers>=5.16 was not pinned yet. The package has required it since generative-computing#130, so the caveat now says a normal install already has it and keeps the ImportError fallback note for older installs. Signed-off-by: samadarsh <samadarsh14@gmail.com>
samadarsh
force-pushed
the
claude/dreamy-bardeen-aovoj2
branch
from
October 9, 2026 10:41
f45fdce to
b9e9495
Compare
The overview still listed "optional trainable switching" with a router, the adapter section said adapters are "router-selected", and the test-directory list still named tests/regression/, which does not exist. MultiSwitch has no trainable router: it derives the per-token adapter index from the control tokens. The test list now names tests/audio/ instead. Signed-off-by: samadarsh <samadarsh14@gmail.com>
samadarsh
force-pushed
the
claude/dreamy-bardeen-aovoj2
branch
from
October 9, 2026 11:40
4a74b97 to
f040fe7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
aviv1ron1
approved these changes
Oct 11, 2026
aviv1ron1
left a comment
aviv1ron1
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the cleanup — we'll follow up separately with some remaining stale hiding-group content
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two docs had drifted from the code.
CLAUDE.md still described the removed SingleSwitch:
hf/switch/single.pyandvllm/switch/single.py; it now listsmulti.py,hf/switch/codes/,conversation.py,token_exchange.py,vllm/audio/andtests/audio/.MultiSwitch/test_multi_switch.py.docs/MULTISWITCH_EXPLAINED.md.uv sync --extra devfails becausedevis a dependency group, so it is nowuv sync --group dev.tests/regression/entry.docs/AUDIO.md said
transformers>=5.16was not pinned yet. The package has required it since #130, so the note now says a normal install already has it, and keeps theImportErrorfallback note for older installs.Testing
Docs only. Pre-commit hooks (including the link validator) pass on both files.