Repository navigation
ref(transport)!: rename and document custom transport factory - #2131
Merged
Merged
Conversation
jpnurmi
added this pull request to stack #2132
September 23, 2026 12:45
jpnurmi
changed the title
jpnurmi
changed the title
jpnurmi
force-pushed
the
jpnurmi/ref/custom-screenshot
branch
from
September 23, 2026 13:25
3214f2f to
545c084
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v1 #2131 +/- ##
==========================================
- Coverage 75.56% 75.49% -0.07%
==========================================
Files 103 103
Lines 28227 28227
Branches 5172 5172
==========================================
- Hits 21330 21311 -19
- Misses 5542 5573 +31
+ Partials 1355 1343 -12 🚀 New features to boost your workflow:
|
jpnurmi
force-pushed
the
jpnurmi/ref/custom-transport
branch
from
September 23, 2026 13:25
67b9ec3 to
780d38a
Compare
mujacica
approved these changes
Sep 24, 2026
jpnurmi
force-pushed
the
jpnurmi/ref/custom-screenshot
branch
from
October 9, 2026 14:26
545c084 to
5b44588
Compare
jpnurmi
force-pushed
the
jpnurmi/ref/custom-transport
branch
2 times, most recently
from
October 15, 2026 07:38
dbfd61d to
9bd987c
Compare
jpnurmi
removed this pull request from stack #2132
October 15, 2026 07:39
jpnurmi
force-pushed
the
jpnurmi/ref/custom-transport
branch
from
October 15, 2026 07:40
9bd987c to
b1e8af6
Compare
The factory used a private-style `sentry__`-prefixed name even though custom transports must provide its implementation. Give it a public-style name and document the contract for custom implementations. BREAKING CHANGE: Custom transport implementations must define: ``` sentry_transport_t *sentry_transport_new_default(void) ```
jpnurmi
force-pushed
the
jpnurmi/ref/custom-transport
branch
from
October 15, 2026 10:09
b1e8af6 to
28f0977
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
BREAKING CHANGE: Custom transport implementations must define:
The factory used a private-style
sentry__-prefixed name even though custom transports must provide its implementation. Give it a public-style name and document the contract for custom implementations.Ref: #2044