ref(transport)!: rename and document custom transport factory

README.md

@@ -251,6 +251,11 @@ using `cmake -D BUILD_SHARED_LIBS=OFF ..`.
     Windows and is the default there.
   - **none**: Do not build any HTTP transport. This should be used if users
     want to handle uploads themselves
+  - **custom**: Provide an external
+    `sentry_transport_t *sentry_transport_new_default(void)` implementation
+    (with `extern "C"` linkage if written in C++). Return a transport created
+    with `sentry_transport_new` or `sentry_http_transport_new`, or `NULL` to
+    disable uploads.
 
 - `SENTRY_SCREENSHOT` (Default: `windows` on Windows, `none` elsewhere):
   Selects the screenshot implementation. Set it to `custom` and provide an

src/sentry_options.c

@@ -107,7 +107,7 @@ sentry_options_new(void)
         false;
 #endif
     opts->backend = sentry__backend_new();
-    opts->transport = sentry__transport_new_default();
+    opts->transport = sentry_transport_new_default();
     opts->refcount = 1;
     opts->shutdown_timeout = SENTRY_DEFAULT_SHUTDOWN_TIMEOUT;
     opts->transfer_timeout = SENTRY_DEFAULT_TRANSFER_TIMEOUT;

src/sentry_transport.h

@@ -46,7 +46,7 @@ int sentry__transport_shutdown(sentry_transport_t *transport, uint64_t timeout);
 /**
  * This will create a new platform specific HTTP transport.
  */
-sentry_transport_t *sentry__transport_new_default(void);
+sentry_transport_t *sentry_transport_new_default(void);
 
 /**
  * This function will instruct the platform specific transport to dump all the

src/transports/sentry_http_transport_curl.c

@@ -547,7 +547,7 @@ curl_send_task(void *_client, sentry_prepared_http_request_t *req,
 }
 
 sentry_transport_t *
-sentry__transport_new_default(void)
+sentry_transport_new_default(void)
 {
     SENTRY_INFO("initializing curl transport");
     curl_client_t *client = curl_client_new();

src/transports/sentry_http_transport_winhttp.c

@@ -410,7 +410,7 @@ exit:;
 }
 
 sentry_transport_t *
-sentry__transport_new_default(void)
+sentry_transport_new_default(void)
 {
     SENTRY_INFO("initializing winhttp transport");
     winhttp_client_t *client = winhttp_client_new();

src/transports/sentry_transport_none.c

@@ -2,7 +2,7 @@
 #include "sentry_transport.h"
 
 sentry_transport_t *
-sentry__transport_new_default(void)
+sentry_transport_new_default(void)
 {
     return NULL;
 }