ref(asgi)!: Drop send_default_pii support when setting user IP address - #7818
Merged
ericapisani merged 1 commit intoOct 1, 2026
Merged
Conversation
Always gate the `user.ip_address` span attribute on `data_collection["user_info"]` instead of falling back to `send_default_pii` when `data_collection` isn't enabled. Update the FastAPI form-data test to use `data_collection` rather than `send_default_pii`. Refs PY-2798 Refs #7566
sentrivana
approved these changes
Oct 1, 2026
Contributor
Codecov Results 📊✅ 58214 passed | ⏭️ 2727 skipped | Total: 60941 | Pass Rate: 95.53% | Execution Time: 161m 20s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2056 uncovered lines. Coverage diff@@ Coverage Diff @@
## master #PR +/-##
==========================================
- Coverage 90.37% 90.15% -0.22%
==========================================
Files 199 185 -14
Lines 26526 20873 -5653
Branches 9866 7256 -2610
==========================================
+ Hits 23971 18817 -5154
- Misses 2555 2056 -499
- Partials 1495 1206 -289Generated by Codecov Action |
ericapisani
deleted the
py-2798-asgi-remove-references-to-send-default-pii
branch
October 1, 2026 14:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always gate the
user.ip_addressspan attribute ondata_collection["user_info"]instead of falling back tosend_default_piiwhendata_collectionisn't enabled.Update the FastAPI form-data test to use
data_collectionrather thansend_default_pii.Refs PY-2798
Refs #7566