Skip to content

ref(asgi)!: Drop send_default_pii support when setting user IP address #7818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericapisani merged 1 commit into from
Oct 1, 2026
+3 −7
Merged

ref(asgi)!: Drop send_default_pii support when setting user IP address #7818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions sentry_sdk/integrations/asgi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
from sentry_sdk.integrations._wsgi_common import (
DEFAULT_HTTP_METHODS_TO_CAPTURE,
)
from sentry_sdk.scope import Scope, should_send_default_pii
from sentry_sdk.scope import Scope
from sentry_sdk.sessions import track_session
from sentry_sdk.traces import (
SegmentNameSource,
Expand All @@ -37,7 +37,6 @@
_is_localhost,
capture_internal_exceptions,
event_from_exception,
has_data_collection_enabled,
logger,
reraise,
)
Expand Down Expand Up @@ -226,10 +225,7 @@ async def _run_app(
ip = _get_ip(scope)
if ip:
client_options = sentry_sdk.get_client().options
if has_data_collection_enabled(client_options):
if client_options["data_collection"]["user_info"]:
sentry_scope.set_attribute(SPANDATA.USER_IP_ADDRESS, ip)
elif should_send_default_pii():
if client_options["data_collection"]["user_info"]:
sentry_scope.set_attribute(SPANDATA.USER_IP_ADDRESS, ip)

if ty in ("http", "websocket"):
Expand Down
2 changes: 1 addition & 1 deletion tests/integrations/fastapi/test_fastapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ async def test_request_info_json_body(sentry_init, capture_items):
async def test_formdata_request_body(sentry_init, capture_items):
sentry_init(
traces_sample_rate=1.0,
send_default_pii=True,
data_collection={},
max_request_body_size="always",
integrations=[StarletteIntegration()],
)
Expand Down
Loading