docker host is trimmed too much in the docs - #317
Merged
Conversation
kokes
marked this pull request as ready for review
September 4, 2026 15:30
andrew
approved these changes
Sep 4, 2026
Contributor
|
Good catch, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When browsing the installation docs in the proxy UI, I noticed the Docker/OCI instructions had a weird trimming issue - "docker pull ackage-proxy..."
Turns out there was a rather rudimentary string slice that assumed https - but when hosted on http, this trims too much.
(I originally planned to parse via net/url, but that seems like overkill since there are only two schemes to consider here.)
(Also the test is a bit meh - feel free to drop it.)