Skip to content

docker host is trimmed too much in the docs #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrew merged 1 commit into from
Sep 4, 2026
Merged

docker host is trimmed too much in the docs #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion internal/server/dashboard.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ func getRegistryConfigs(baseURL string) []RegistryConfig {
if strings.HasPrefix(strings.ToLower(baseURL), "http://") {
swiftInsecureFlag = "--allow-insecure-http "
}
dockerHost := strings.TrimPrefix(strings.TrimPrefix(baseURL, "https://"), "http://")

return []RegistryConfig{
{
Expand Down Expand Up @@ -433,7 +434,7 @@ using Pkg; Pkg.update()</code></pre>`),
sudo systemctl restart docker

# Or pull directly
docker pull ` + baseURL[8:] + `/library/nginx:latest</code></pre>`),
docker pull ` + dockerHost + `/library/nginx:latest</code></pre>`),
},
{
ID: "deb",
Expand Down
15 changes: 15 additions & 0 deletions internal/server/templates_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,21 @@ func TestEcosystemBadgeLabel(t *testing.T) {
}
}

func TestOCIRegistryInstructionsDockerPull(t *testing.T) {
registries := getRegistryConfigs("http://package-proxy:8080")
for _, registry := range registries {
if registry.ID != "oci" {
continue
}
want := "docker pull package-proxy:8080/library/nginx:latest"
if !strings.Contains(string(registry.Instructions), want) {
t.Errorf("OCI instructions = %q, want substring %q", registry.Instructions, want)
}
return
}
t.Fatal("OCI registry instructions not found")
}

func TestSwiftRegistryInstructionsAllowLocalHTTP(t *testing.T) {
registries := getRegistryConfigs("http://localhost:8080")
for _, registry := range registries {
Expand Down
Loading