fix(cli): update Puppeteer browser dependencies - #4030
Closed
heygengenesis[bot] wants to merge 1 commit into
Closed
heygengenesis[bot] wants to merge 1 commit into
heygengenesis[bot] wants to merge 1 commit into
Conversation
heygengenesis
Bot
force-pushed
the
bugfix/1787766784-windows-puppeteer-322
branch
from
September 17, 2026 04:18
59f9c1c to
232a8d1
Compare
miguel-heygen
approved these changes
Sep 17, 2026
Update the CLI Puppeteer browser dependencies and regenerate the lockfile. Co-authored-by: miguel.sierra <229591595+miguel-heygen@users.noreply.github.com>
heygengenesis
Bot
force-pushed
the
bugfix/1787766784-windows-puppeteer-322
branch
from
September 20, 2026 22:07
232a8d1 to
e067906
Compare
Collaborator
Contributor
|
Superseded by #4233, which carries the identical manifest change ( One thing did not travel with the supersede: the open question of whether the bump actually removes the stray console windows on Windows. CI observes that the render path launches and completes, which is a different observation. That confirmation is still unmade against — Miga |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #4028.
Update the CLI manifest from
@puppeteer/browsers^3.2.1to^3.2.2andpuppeteer-core^25.8.0to^25.10.0. The CLI has no directpuppeteerdependency.Why
The upstream basis, not proof for this repository, is Puppeteer PR #15415, commit
a84b0325de0e860c9c4b60de7bff7c0ae100accd, released in@puppeteer/browsers3.2.2. The upstream “fixed in 3.2.2” claim is explicitly UNVERIFIED for the reported console-window symptom in this repository.How
This branch was rebased onto
mainatf92d017b999d26b14c49a8439dc16d2e476bffde. The frozen lock resolutions now select@puppeteer/browsers3.2.2 andpuppeteer-core25.11.0 for the CLI's^25.10.0range. The lockfile was regenerated with Bun 1.4.2; it also refreshes stale workspace metadata from 0.8.50 to 0.8.57 and records the transitivedevtools-protocol0.0.1666840 → 0.0.1680125 andwebdriver-bidi-protocol0.4.2 → 0.4.3 resolutions. Existingpuppeteer@25.8.0consumers retain their nested legacy graph.Manifest evidence:
@puppeteer/browsersL34 andpuppeteer-coreL48. Lock evidence:@puppeteer/browsersL1056 andpuppeteer-coreL1904.Reviewer advisory: only the CLI manifest ranges changed. The regenerated shared lock resolution is not a runtime-test claim for any other workspace.
Test plan
bun install --lockfile-onlypassed with Bun 1.4.2.bun install --frozen-lockfile --ignore-scriptspassed and leftbun.lockunchanged.bunx oxfmt --check packages/cli/package.json,bun run --cwd packages/cli typecheck, and the targeted browser tests (58 tests) passed.bunx fallow audit --base origin/main --fail-on-issuespassed; no reductions found.The upstream “fixed in 3.2.2” claim remains explicitly UNVERIFIED for the reported console-window symptom. A Linux sandbox cannot perform a Windows visual/native-console repro.
Render on windows-latestis required on this new head. Its green result proves only that the Windows install/build/render path launches and completes at the updated version; it does NOT observe or enumerate the reported 78 console windows, window visibility, or focus. A human on Windows must confirm the symptom is gone before merge.Unit tests added/updated — dependency and lock-only change.
Manual testing performed — lock regeneration and dependency-resolution validation.
Documentation updated (if applicable) — not applicable.