fix(cli): update Puppeteer browser dependencies - #4233
Merged
Merged
Conversation
Bump @puppeteer/browsers to ^3.2.2 and puppeteer-core to ^25.10.0 so Chrome spawns detached only off Windows (upstream puppeteer #15415). Lock regenerated on top of main. Fixes #4028.
1 of 3 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Supersedes #4030, which conflicted with main on the lock file. Same change:
@puppeteer/browsers^3.2.1→^3.2.2andpuppeteer-core^25.8.0→^25.10.0in the CLI manifest, lock regenerated on top of current main.Fixes #4028.
Why
@puppeteer/browsers3.2.2 restores the detached-spawn default toprocess.platform !== 'win32'(upstream puppeteer/puppeteer#15415), which is the Windows spawn behaviour the CLI relies on.How
Two files:
packages/cli/package.jsonandbun.lock. Lock resolutions move to@puppeteer/browsers@3.2.2andpuppeteer-core@25.11.0.Test plan