Conversation
This was referenced Sep 22, 2026
NullVoxPopuli-ai-agent
pushed a commit
to NullVoxPopuli-ai-agent/table
that referenced
this pull request
Sep 22, 2026
…@options - Column and Table default their cell args to `any`, so `Column<Person>` and `Table<Person>` accept a column or table whose Cells take extra args. The plugin helpers (`sort`, `isVisible`, `hide`, ...) take them with no change to their signatures. Tables from headlessTable still carry their inferred args. - `row.table` has the types of the table, like `column.table`, in the rows of a table and in `CellContext`. - `getOptionsForRow` has the `@options` that the Cells ask for, as in johanrd#5. - Tests: each column decides which Cell fits it through its own meta, the plugin helpers accept a column with cell args, and a Cell renders with `@options={{column.getOptionsForRow row}}`. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
`CellOptions` is what the `options` callback of a column config must return, and `CellOptionsOf` is what `getOptionsForRow` gives a Cell. Both are part of the surface an app writes against, but neither could be named. Cowritten by Claude
johanrd
force-pushed
the
options-for-row
branch
from
September 22, 2026 23:14
f929dc7 to
55f7f8b
Compare
johanrd
changed the title
Owner
Author
|
superseded by universal-ember#203 |
NullVoxPopuli
added a commit
to universal-ember/table
that referenced
this pull request
Sep 23, 2026
…red lists - A column list with a declared type keeps its cell args, like it keeps its column meta. A shared component that takes `ColumnConfig<Row, unknown, unknown, CellArgs>[]` from its caller can build the table (johanrd#6). - Each column written in place is checked on its own: its Cell takes the row type, the column's meta and the table meta, and when the Cell asks for `@options`, the column's `options` returns them. - A table `meta` together with a callback that has parameters no longer loses the inferred cell args and column meta. The Cell check read the column list while TypeScript was still inferring it. - `CellOptions` and `CellOptionsOf` are exported (johanrd#5). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased onto 60dafd9, which already types
getOptionsForRowfrom the Cell'soptionsarg — the sameCellOptionsOfthis PR carried. Only the exports are left.CellOptionsis the return type of theoptionscallback in a column config, andCellOptionsOfis whatgetOptionsForRowhands a Cell. Both are part of the surface an app writes against, but neither can be named today:public-option-types.test.tscovers both. The package is clean.Cowritten by Claude