Skip to content

fix(model): export object! macro without the macros feature - #1318

Merged
DaleSeo merged 1 commit into
mainfrom
DaleSeo/the-rmcp-lib-test-target-does-not-build-without
Oct 5, 2026
Merged

fix(model): export object! macro without the macros feature#1318
DaleSeo merged 1 commit into
mainfrom
DaleSeo/the-rmcp-lib-test-target-does-not-build-without

Conversation

@DaleSeo

@DaleSeo DaleSeo commented Oct 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #1317.

Motivation and Context

Removes the macros feature gate from the object! macro so it is always exported, and adds a CI step that runs the rmcp lib tests with --no-default-features.

How Has This Been Tested?

  • cargo test -p rmcp --lib --no-default-features
  • cargo check -p rmcp --all-features

Breaking Changes

None.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@github-actions github-actions Bot added T-CI Changes to CI/CD workflows and configuration T-config Configuration file changes T-core Core library changes labels Oct 4, 2026
@DaleSeo
DaleSeo marked this pull request as ready for review October 4, 2026 01:08
@DaleSeo
DaleSeo requested a review from a team as a code owner October 4, 2026 01:08
@DaleSeo DaleSeo self-assigned this Oct 4, 2026
@ragen1337 ragen1337 mentioned this pull request Oct 4, 2026
Open
@chrikrah chrikrah mentioned this pull request Oct 4, 2026
Merged
5 of 9 tasks
@DaleSeo
DaleSeo force-pushed the DaleSeo/the-rmcp-lib-test-target-does-not-build-without branch from 67764c9 to 8feb877 Compare October 5, 2026 14:02
@DaleSeo
DaleSeo changed the base branch from main to fix/msrv-resolver October 5, 2026 14:02
Base automatically changed from fix/msrv-resolver to main October 5, 2026 14:03
alexhancock
alexhancock approved these changes Oct 5, 2026
View reviewed changes
Comment thread Cargo.toml

@alexhancock alexhancock Oct 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this will go away in a rebase?

@DaleSeo
DaleSeo force-pushed the DaleSeo/the-rmcp-lib-test-target-does-not-build-without branch from 8feb877 to e0743c7 Compare October 5, 2026 14:21
@DaleSeo
DaleSeo merged commit deef9bb into main Oct 5, 2026
24 checks passed
@DaleSeo
DaleSeo deleted the DaleSeo/the-rmcp-lib-test-target-does-not-build-without branch October 5, 2026 14:52
@github-actions github-actions Bot mentioned this pull request Oct 5, 2026
Merged
@DaleSeo DaleSeo mentioned this pull request Oct 5, 2026
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexhancock alexhancock alexhancock approved these changes

Assignees

@DaleSeo DaleSeo

Labels

T-CI Changes to CI/CD workflows and configuration T-config Configuration file changes T-core Core library changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The rmcp lib test target does not build without the macros feature

2 participants

@DaleSeo @alexhancock