Skip to content

docs: re-anchor the last dead tracker citations in eleven lane packages' files outside src to the commits that decided them - #20923

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-20594-lane-outside-src
Sep 30, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-20594-lane-outside-src

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Part of #20594
Clause-②: no

What changed

This is stage 16 of the domain:cli lane's dead-citation sweep: the 17 comment sites left in eleven lane packages' files outside src/** (claim 5917064266; the list on stage 15's landing 5916232164). The file surface is the one stage 14 set: README.md, tsconfig*.json, vitest.config.*, tsup.config.* and test/**.

Every comment site on that surface whose tracker number answers 404 now cites the commit that decided what the line describes, in ruling C+D's form C (comment 5749154545 on #19123). Stages 1 to 15 of this card are the precedents; the latest are PR #20883 and PR #20898.

Census

Instrument. The card's gate does not read these files (its declared surface is packages/**/src/**), so the census is taken by hand with the gate's own grammar, as stages 14 and 15 took it:

  • Files: every tracked file of the eleven packages outside src/**, with CHANGELOG.md left out: 81 files. Each is classed ON stage 14's file list (48 files) or OFF it (33: package.json, LICENSE, ledgers, objectstack.config.ts and the like). Only ON-list comment sites are this stage's.
  • Extraction: extractCitations from scripts/check-issue-citations.mjs, with its comment-prose projection for code and JSONC files and the whole file for *.md. The whole-file extraction minus the comment projection gives the string sites.
  • Numbers kept: only those naming this repository (namesThisRepository).
  • Probe: each distinct number, GET /repos/objectstack-ai/objectstack/issues/N; 404 means dead.
tree probe window (UTC) numbers answer 200 answer 404 dead comment sites, on-list comment sites dead comment sites, off-list dead string sites
before base cb4c31dd52 2026-09-30 18:18:37 to 18:19:15 94 80 14 17 (9 numbers, 14 files) 212 2 11
after head 1e3782200f 2026-09-30 18:23:26 to 18:24:03 88 80 8 0 195 2 11

Per package, dead on-list comment sites, before to after:

package before after
packages/plugins/plugin-hono-server 4 0
packages/plugins/plugin-dev 2 0
packages/client 2 0
packages/qa/vitest-filter-preflight 2 0
packages/cloud-connection 1 0
packages/mcp 1 0
packages/qa/downstream-contract 1 0
packages/rest 1 0
packages/runtime 1 0
packages/types 1 0
packages/verify 1 0
total 17 0

Per-number anchors

Each anchor was checked by blame on the site and in the anchor's own message or diff. "Reused" names earlier stages that gave the number the same anchor.

number sites anchor what it decided
#13176 4: plugin-hono-server and plugin-dev tsconfig.test.json (:3 and :61 / :56) a68c61267 plugin-security's test layer enters tsc under a sibling tsconfig.test.json at zero residue, with no test-typecheck-debt.json; its diff writes the number into that config's header and into the TEST_DEBT graduation reused (plugin-security)
#11332 1: plugin-hono-server tsconfig.typecheck.json:12 dce5cd4f0 retires the manifest's capabilities / configuration / extensions containers as retiredKey() tombstones (ADR-0049); its changeset names the number reused (spec)
#10724 1: the same line be21955ba retires the nine dead contributes members as retiredKey() tombstones (ADR-0049); its subject names the number reused (spec)
#12181 2: client tsconfig.json:8, vitest.config.ts:33 cf71d73f8 meta.deleteItem's reset carriers; this same commit wrote both blocks (the paths rules and the alias for the real-door test), and its changeset names the number reused (client, cli)
#17853 5: vitest-filter-preflight's two test headers, rest / runtime / types vitest.config.ts 08f5f0e5a a vitest filter that selects no test file says so; its message names the card it lands. The sentence in the three configs is the one stage 14 and stage 15 rewrote in cli's and dogfood's reused (qa, cli, dogfood)
#16917 1: cloud-connection vitest.config.ts:64 7ce3154e6 the comment-only repair of this file, which wrote the "paraphrased rather than quoted" sentence; its message names the card it lands new
#8651 1: mcp vitest.config.ts:18 8c65046e4 pins mcp's three engine doubles to metadata-core's dispatch predicates, adds that devDependency and creates this config for the alias; its message names the card it lands new
#10485 1: downstream-contract test/contract.test.ts:46 35ad101bc retires ThemeSchema and the themes carrier key (ADR-0049, kept beside it); its subject names the number, and it wrote this line reused (spec, qa, cli)
#15145 1: verify tsconfig.test.json:1 45a72b0cc wires verify's test layer into typecheck through this file; its diff writes the number into this line and into the coverage-ledger graduation new

ADR and ruling records. A grep of docs/adr and scripts/adr-anchors for the 9 numbers finds one hit: ADR-0088 names #10724 in a correction note (history, not the ruling), so that number stays on the commit every earlier stage anchored it to. The sentence it sits in already names ADR-0049. The control number 7329 finds 1 file in the same tree.

Anchor checks:

  • Each sha is unambiguous: git rev-parse --disambiguate gives count 1 for each of the 9.
  • Each is a plain commit with one parent.
  • Each is on the base: merge-base --is-ancestor against cb4c31dd52 exits 0 for all 9.
  • The history is complete: the checkout is not shallow. Control leg: 01218124ae, the parent of the oldest anchor 8c65046e4 (2026-08-16), exits 0. Negative control: the base as an ancestor of 8c65046e4 exits 1.

Verification

All at head 1e3782200f. Heavy runs went through scripts/pm/os-verify-lock.sh with OS_VERIFY_LOCK_SLOT=issue-20594-outside.

  • Build (whole workspace): pnpm exec turbo run build --filter='./packages/*' --filter='./packages/*/*' --concurrency=2 → 71 successful, 71 total (9 cached), lock verdict command-exit 0.
  • Typecheck, ten packages (cloud-connection declares no typecheck script): pnpm --workspace-concurrency=2 --filter plugin-hono-server, plugin-dev, client, vitest-filter-preflight, mcp, downstream-contract, rest, runtime, types, verify run typecheck → 10 of 10 Done, 0 error TS, lock verdict command-exit 0. That reads every touched JSONC config (plugin-hono-server's runs tsconfig.typecheck.json by name; the tsconfig.test.json files are read by check:test-typecheck, all at their recorded ledgers). --listFilesOnly holds all 3 touched test files in their packages' programs.
  • Tests, by name (one lock call, verdict command-exit 0). Each touched test file ran, and each touched vitest.config.ts was loaded by a run of its own package:
    • vitest-filter-preflight: test/config-wiring-sweep.test.ts, test/filter-preflight.test.ts → 2 files, 97 tests passed.
    • downstream-contract: test/contract.test.ts → 1 file, 13 tests passed.
    • client: src/meta-delete-item-carriers.test.ts (the suite the edited alias block serves) → 20 passed.
    • cloud-connection: src/canonical-expression-envelopes.test.ts (the suite the alias exists for) → 16 passed.
    • mcp: src/mcp-stdio-tools.test.ts (the engine doubles the edited block describes) → 12 passed.
    • rest, runtime, types (--project local): src/rest-exec-ctx-memo.test.ts 4 passed, src/app-plugin.ordering.test.ts 3 passed, src/email-verified.test.ts 2 passed.
  • Token guard, base cb4c31dd52 against head, 14 files, 5,764 base tokens: 0 files differ. TypeScript files are compared as leaf tokens (getChildren, JSDoc nodes skipped), JSONC files as the scanner's non-trivia token stream plus their parsed value (0 of 5 values differ). Controls, in memory only: a comment inserted into each file, 0 of 14 differ; a statement appended, 14 of 14; one character flipped inside each file's first string token, 14 of 14 (9 StringLiteral, 5 JSON strings).
  • Control bytes: a scan of the 14 files finds 0 (positive control, a scratch file holding U+0001: 1). pnpm check:nul-bytes exits 0.
  • Nothing publishes. npm pack --dry-run in each of the 9 public packages packs only dist/**, README.md, CHANGELOG.md, LICENSE and package.json: 0 of the 11 touched files in those packages is packed. After the build, the first 48 characters of each of the 16 added comment lines occur in 0 files of any package's dist/; control: a src docblock phrase an earlier stage wrote ("Maintainer-seat ruling, landed by commit cf71d73") occurs in packages/client/dist/index.d.ts. The other two packages are private.

Gates

All at head 1e3782200f, exit codes captured before any pipe.

  • Derivation: node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands, no paths, derives 52 commands (14 paths against merge base cb4c31dd52). Re-derived after fetching origin/main to 4d0b9cd542: the same 52, and none of the 4 upstream commits touches a derivation input or a file here.
  • All 52 exit 0, each on its first run.
  • Reconciliation: dispatch-gates --ran over the recorded COMMAND :: exit CODE list → "52 derived, 52 run, 0 NOT-MEASURED, 0 UNRUN", exit 0.
  • Roster gates the derivation marks as keeping a roster under packages/: pnpm check:authz-resolver, pnpm check:error-code-casing and pnpm check:filter-alias-parity → exit 0 each.
  • pnpm lint (repo-wide eslint . --no-inline-config, the family the derivation does not name) → exit 0, 2026-09-30T18:26:35Z to 18:30:31Z.
  • node scripts/check-issue-citations.mjs (diff mode, in the 52) reads 0 files, because none of these paths is on its declared surface; the hand census above is the measurement for this surface.
  • A local git merge-tree --write-tree of this head against origin/main 4d0b9cd542 is clean.

The 52 derived commands: stage 15's list with pnpm --filter @objectstack/spec run check:skill-examples and node scripts/check-tenant-audit-census.mjs (with its --self-test) in, and check:empty-state, check:liveness, check:strictness-ledger and check:variant-docs (spec) out:

  • node scripts/check-ci-filter-parity.mjs
  • node scripts/check-closing-keyword-parity.mjs and --self-test
  • node scripts/check-comment-mask-adoption.mjs and --self-test
  • node scripts/check-comment-mask-corpus.mjs
  • node scripts/check-issue-citations.mjs
  • node scripts/check-keyed-text-bounds.mjs and --self-test
  • node scripts/check-platform-object-tenancy-census.mjs and --self-test
  • node scripts/check-plugin-teardown-shape.mjs and --self-test
  • node scripts/check-registry-log-declared.mjs and --self-test
  • node scripts/check-rest-log-spy-declared.mjs and --self-test
  • node scripts/check-system-context-census.mjs and --self-test
  • node scripts/check-tenant-audit-census.mjs and --self-test
  • node scripts/check-undeclared-dep-imports.mjs and --self-test
  • node scripts/docs-audit/check-affected-docs.mjs
  • node scripts/docs-audit/check-drift-comment.mjs
  • pnpm --filter @objectstack/spec run check:skill-examples
  • pnpm check:cross-package-test-inputs, check:dispatcher-error-vocabulary, check:doc-authoring, check:driver-memory-census, check:dts-closure, check:dual-build-cjs-loads, check:engine-double-contract, check:gitlink-declared, check:issue-citations, check:lean-entry-closure, check:logger-receiver-detach, check:nul-bytes, check:objectql-double-limit, check:org-identifier, check:page-declaration-shape, check:published-files, check:query-options-erasure, check:refd-timer-probe, check:slot-lookup, check:sourcemap-no-sources-content, check:test-source-alias, check:tier-file-adoption, check:type-check-coverage, check:type-check-debt, check:watch-hint-literal, check:where-matcher

Acceptance notes


Generated by Claude Code

…packages' files outside src to the commits that decided them

Stage 16 of the domain:cli lane's dead-citation sweep: 17 comment sites on
16 lines in 14 config and test files (tsconfig*.json, vitest.config.ts,
test/**) across plugin-hono-server, plugin-dev, client,
qa/vitest-filter-preflight, cloud-connection, mcp, qa/downstream-contract,
rest, runtime, types and verify. Each dead number now cites the commit that
decided it, in ruling C+D's form C; comments only, every file keeps its
line count.

Claude-Session: https://claude.ai/code/session_01VvcEokUG1tvVxkceYfR5XB
Co-authored-by: Claude <noreply@anthropic.com>
@objectstack-fleet objectstack-fleet Bot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

⚠️ 8 changed file(s) yielded no anchor (packages/client/tsconfig.json, packages/client/vitest.config.ts, packages/cloud-connection/vitest.config.ts, …), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files. Nothing else in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 7 changed package(s)).

What this run could not see
  • 8 changed file(s) yielded no anchor (packages/client/tsconfig.json, packages/client/vitest.config.ts, packages/cloud-connection/vitest.config.ts, …) — pages documenting those are invisible to this run
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.
  • a key NAME is not a key, so the hand re-read the line above prescribes can land on the wrong schema. The same spelling is authorable on one governed type and a [REMOVED] tombstone on another for each of active, aria, joins, objects, template, tools and version (censused on [finding] tools is a key on BOTH AgentSchema (tombstoned, dead) and SkillSchema (live, cloud-attested), so a name-based search attributes skill examples to the agent key — it produced a false stop-the-line alarm on PR #19059 #19093 over the liveness ledger's governed types, top-level keys); nothing in a search result distinguishes the two, so a grep hit on a LIVE example reads as evidence about the DEAD key. Measured on fix(spec): the agent.tools liveness row says dead — it claimed live on a key the schema tombstoned #19059: content/docs/ai/agents.mdx was reported as contradicting the agent.tools tombstone over its tools: example at :161, which is inside the defineSkill({ block opened at :155 — the page was already correct. Settle ownership by PARSING the value against both schemas, never by the name: that literal PASSES SkillSchema, and as an AgentSchema it FAILS at tools with the tombstone prescription. ⛔ These names are not the whole class — a key retired through a .strict() guidance map leaves no tombstone in the walked shape and none of them here (tool.category, live as AIToolDefinition.category).

Coarse fallback — 48 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 4d0b9cd542c973f8914236db23efdde9adc76e4c → packageMentionDocs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s skip-changeset PR has no user-facing published change; bypasses the changeset gate tests tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants