fix: bound shared text and byte helpers - #1029
Merged
Merged
Conversation
andiwand
force-pushed
the
review/10-portable-smoke-tests
branch
from
October 4, 2026 20:30
bebc4c0 to
0292300
Compare
andiwand
force-pushed
the
review/11-global-core
branch
from
October 4, 2026 20:38
b6c13b9 to
2aec3ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Shared ASCII helpers changed behavior under a Turkish host locale, empty replacement patterns could loop forever, and byte-patch offsets could wrap past their bounds checks. Use explicit ASCII rules, reject invalid replacement/repetition sizes, count UTF-8 with validation, and check remaining bytes before patching. Empty case-insensitive searches now follow string search semantics.
This is the first layer of the continuing file-by-file review, based on #1028. It fixes common helpers so their rendering and parsing callers share the correction. Existing search tests cover the added empty-needle cases; four small regression cases cover the other missing boundaries.
Validation: library/test build; 23 targeted tests passed, including the installed Turkish locale. Full-repository manual review is still in progress.