Repository navigation
fix: report failed copies and preserve text on save - #1030
Merged
Merged
Conversation
andiwand
force-pushed
the
review/11-global-core
branch
from
October 4, 2026 20:38
b6c13b9 to
2aec3ad
Compare
TemporaryDiskFileFactory::copy is [[nodiscard]], so the bare call in EXPECT_THROW gives -Wunused-result, which -Werror on CI turns into an error. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
force-pushed
the
review/12-io-failures
branch
from
October 4, 2026 20:44
8f40d0f to
c6b7c04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Saving an unedited text file over its source opened the destination before reading the text and could empty it. Read before truncation. Shared stream copies now report failed reads and writes, disk writes check close/flush, and failed temporary copies remove their partial output.
Magic and encoding probes reuse the bounded stream reader, removing two copies of that code and inheriting its error checks. Three focused regressions cover source aliasing, failed temporary-copy cleanup, and stream failures; existing text and ZIP coverage checks callers.
Validation: test build and 62 targeted tests passed. The full repository review continues.