Repository navigation
fix: copy filesystem walkers without shared traversal - #1031
Merged
Merged
Conversation
andiwand
force-pushed
the
review/12-io-failures
branch
from
October 4, 2026 20:44
8f40d0f to
c6b7c04
Compare
filesystem.cpp throws std::runtime_error, and the test uses std::filesystem and std::error_code. They compiled only through other headers. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
force-pushed
the
review/13-walker-copies
branch
from
October 4, 2026 20:50
c8c444f to
bed4ee2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Copying a disk-backed
FileWalkercopied a single-pass filesystem iterator, so advancing either walker also advanced the other. A copy now opens its own traversal and positions it at the same entry; equality compares traversal roots and positions.Copying costs a replay from the walked directory. Normal traversal keeps its existing streaming behavior and memory use. This is preferable to eagerly snapshotting every directory for a rarely used copy operation.
One shared regression exercises independent copies at every position, including nested entries and the end, for both disk and virtual filesystems. Validation: 28 filesystem/file tests passed.