Repository navigation
fix: handle empty public handles and related elements - #1032
Merged
Merged
Conversation
andiwand
force-pushed
the
review/13-walker-copies
branch
from
October 4, 2026 20:50
c8c444f to
bed4ee2
Compare
The test sat between an existing comment and the test that the comment describes. It now comes before that comment and uses the `html` suite of the file. The getters are [[nodiscard]], so the test discards their results through std::ignore, because -Werror on CI rejects -Wunused-result. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
force-pushed
the
review/14-public-handles
branch
from
October 4, 2026 20:58
9b73920 to
a93e2b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Opening/probing a default
Fileand accessing default HTML handles dereferenced null. Those boundaries now throwNullPointerError. Related-element readers reuse the existing checked narrowing operations, so absent master pages and table rows/columns return empty handles without querying adapter ID zero. Document edits also reject an empty element before dispatching it.Three regression cases cover file probes, HTML handles and missing ODF elements. Validation: library/test build, public C++20 headers, and 131 document/edit/file tests passed.