fix: validate edit integers before narrowing - #1033
Merged
Merged
Conversation
andiwand
force-pushed
the
review/14-public-handles
branch
from
October 4, 2026 20:58
9b73920 to
a93e2b5
Compare
andiwand
force-pushed
the
review/15-edit-integers
branch
from
October 4, 2026 21:05
76476c7 to
43af35d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
JSON numeric conversions could wrap a row, column or sheet index to another cell, truncate fractions, and reinterpret an unsigned element ID as a negative ID created earlier in the same edit. Validate integer types and ranges before narrowing, and retain unsigned identifiers at their full width. Text/document envelopes also reject truncated versions and non-array operations.
Two new document regressions cover invalid targets and unsigned-ID aliasing; the existing text-envelope test covers the new validation. Validation: 101 document-edit/text tests passed.