Repository navigation
fix: retain CFB stream metadata and traversal context - #1034
Merged
Merged
Conversation
andiwand
force-pushed
the
review/15-edit-integers
branch
from
October 4, 2026 21:05
76476c7 to
43af35d
Compare
andiwand
force-pushed
the
review/16-cfb-ownership
branch
from
October 4, 2026 21:11
acb9369 to
56ae165
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
A CFB stream retained a pointer to metadata owned by its file wrapper, although streams can outlive that wrapper. Copy the small directory entry into the stream buffer. Nested directory walks now retain the boundary between inner and outer sibling stacks, so a child's siblings finish before traversal returns to its parent. Unwinding directories is iterative.
The binary reader also uses checked sector reads, widens directory offsets before multiplication on 32-bit targets, and avoids fetching the next sector after the requested bytes are complete. Packed fields use
std::array, with layout-size assertions, and their comments are shorter.Two regressions cover stream ownership and a synthetic nested CFB tree. Validation: 38 CFB, legacy Office, crypto and document-file tests passed.