Repository navigation
fix: isolate ZIP reader errors and preserve full entry names - #1040
Merged
Merged
Conversation
andiwand
force-pushed
the
review/21-xml-input
branch
from
October 5, 2026 06:46
058564a to
8421f8e
Compare
andiwand
force-pushed
the
review/22-archive-metadata
branch
from
October 5, 2026 07:02
cdcec94 to
84f1751
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
ZIP entries with names longer than miniz's fixed stat buffer were truncated and could collide in the filesystem view. Read the full filename length, reject embedded NULs, and include archive identity when comparing entries.
Each extraction and metadata read now copies miniz's mutable error state while sharing its immutable directory data. Concurrent failures and early stream closure no longer write the same error field. Check entry-size and stream-offset conversions, reject unseekable output, and clean up initialization that throws.
Validation: 142 ZIP, document-file, ODF, and OOXML tests pass, including long-name separation, concurrent corrupt reads, successful parallel reads, and allocation cleanup after early closure.