Repository navigation
fix: validate CFB mini streams and legacy sizes - #1041
Merged
Merged
Conversation
andiwand
force-pushed
the
review/22-archive-metadata
branch
from
October 5, 2026 07:02
cdcec94 to
84f1751
Compare
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
force-pushed
the
review/23-cfb-validation
branch
from
October 5, 2026 07:08
f7ae468 to
f5744fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
CFB now checks the header's byte order, mini-sector size and cutoff, the root entry type, and directory-name length/termination. Mini-sector reads must stay inside the root mini stream, not merely inside the containing file. Empty reads do not traverse sector chains.
For version 3 files, ignore the high size DWORD as required for older writers by MS-CFB 2.6.1. Version 4 entry sizes are checked before narrowing to size_t.
Validation: 40 CFB, legacy Office, OOXML crypto, and document-file tests pass. Synthetic fixtures cover malformed headers/names, legacy size words, and invalid mini-sector references. Rules checked against vendored MS-CFB sections 2.2, 2.4, and 2.6.1.