Repository navigation
fix: validate BIFF record and worksheet boundaries - #1054
Merged
Merged
Conversation
andiwand
force-pushed
the
review/35-doc-table-bounds
branch
from
October 5, 2026 09:06
4594dc0 to
c1bbcc0
Compare
LibreOffice opens a workbook with these quirks, so the parser now accepts them too: a cell outside the BIFF8 grid is dropped, Dimensions is clamped, MulRk ignores colLast, a string formula without its String record stays empty, a clean end of stream ends a substream, and cstTotal is not checked. The record bounds stay strict. Skipped bodies use byte_stream::skip. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
force-pushed
the
review/36-xls-record-validation
branch
from
October 5, 2026 09:26
ad4a373 to
916f8c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Legacy Excel now distinguishes truncated BIFF records from a clean end of stream, checks skipped bodies, and requires the right substream type in BOF. As in LibreOffice, a cell outside the BIFF8 grid is dropped, Dimensions is clamped, MulRk ignores colLast, and a string formula without its String record stays empty. SST storage grows with the strings read and does not trust the declared count. Numeric formatting uses locale-independent fmt.
Validation: 25 Excel/encryption tests pass, including six XLS corpus cases. Focused regressions cover partial headers, skipped bodies, missing terminators, count/range errors, MulRk’s final column, and a German numeric locale.