Repository navigation
fix: preserve ODF chart data positions - #1087
Merged
Merged
Conversation
andiwand
force-pushed
the
review/68-odf-format-bounds
branch
from
October 5, 2026 18:39
af969e3 to
4a29c2f
Compare
count_cells returns more than the limit for an oversized header, which read_data then used as the number of leading columns. Refuse it there, so the replacement image shows. Move the AGENTS.md note on the chart limit out of the open work list. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
force-pushed
the
review/69-odf-chart-data
branch
from
October 5, 2026 18:48
edef8ab to
32c91f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
ODF charts preserve category positions across short and repeated table rows, and retain every implicit series when the chart omits series declarations. Previously, later points shifted into earlier categories and implicit charts kept only one series. Expanded rows and the resulting data grid are limited to 1,048,576 entries; oversized tables use the existing replacement-image fallback.
Two focused regressions check plotted coordinates for explicit/implicit series and repeated-table bounds. All 71 checks pass, including 55 ODS HTML corpus cases. The changed production file passes clang-tidy.