Repository navigation
fix: validate ODF chart geometry and pie arcs - #1088
Merged
Merged
Conversation
andiwand
force-pushed
the
review/69-odf-chart-data
branch
from
October 5, 2026 18:48
edef8ab to
32c91f7
Compare
The PR padded a constant series by 10% on both sides, which moves the axis of every chart with one repeated value. Keep the old padding of 1, and grow it only where the value is so large that 1 is lost. The label stride no longer uses std::clamp, which is undefined for no categories. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
force-pushed
the
review/70-odf-chart-geometry
branch
from
October 5, 2026 18:57
0842929 to
3d65efe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
ODF charts validate plot geometry and axis intervals before converting them to integers, clamp label spacing to the category count, and fall back when coordinates cannot be represented. Numeric values use the existing locale-independent parser. Pie totals are normalized before summing, and each slice uses two arcs so a single nonzero slice draws a complete circle or ring.
The existing single-slice regression now checks the arc count; two additional cases cover invalid/extreme geometry and overflowing pie totals. All 73 targeted checks pass, including 55 ODS corpus cases. The changed production file passes clang-tidy.